Skip to content

docs: Clarify naming conventions for deletion_protection#8944

Merged
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
bw-yuhogg:delete-protection-clarify
Sep 14, 2023
Merged

docs: Clarify naming conventions for deletion_protection#8944
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
bw-yuhogg:delete-protection-clarify

Conversation

@bw-yuhogg

@bw-yuhogg bw-yuhogg commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

If your API does not literally call its field deletion_protection, neither should your Terraform field.

Release Note Template for Downstream PRs (will be copied)

If your API does not literally call its field `deletion_protection`,
neither should your Terraform field.
@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3037
Passed tests 2736
Skipped tests: 297
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample|TestAccMonitoringMonitoredProject_projectNumShortForm|TestAccMonitoringMonitoredProject_projectNumLongForm|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample[Debug log]
TestAccMonitoringMonitoredProject_projectNumShortForm[Debug log]
TestAccMonitoringMonitoredProject_projectNumLongForm[Debug log]
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@c2thorn c2thorn requested review from c2thorn and removed request for SarahFrench September 14, 2023 14:53
@c2thorn

c2thorn commented Sep 14, 2023

Copy link
Copy Markdown
Member

Taking over the review based on earlier conversation

@c2thorn c2thorn merged commit 3b4a143 into GoogleCloudPlatform:main Sep 14, 2023
@bw-yuhogg bw-yuhogg deleted the delete-protection-clarify branch September 14, 2023 14:55
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants