Fix provider configuration code to handle Unknown values correctly#8943
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
70f072d to
0c5b503
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 230 insertions(+), 183 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample|TestAccMonitoringMonitoredProject_projectNumShortForm|TestAccMonitoringMonitoredProject_projectNumLongForm|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
… `credentials` tests pass
…, make those tests pass
…be set to same defaults as if they were null, update test
…etBatchingConfig` is used by the code
…ntDelegates values
0c5b503 to
cd9fde2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
I've yet to manually test this change to see if this use case from the original issue works as expected again: |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 227 insertions(+), 175 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountIdToken_impersonation |
|
Rerun these tests in REPLAYING mode to catch issues
|
…rovider config Only testing `credentials` currently.
|
I manually tested the use case from the original issue (see comment) and I've added a non-VCR acceptance test that asserts the provider's behaviour. I've tried to implement that test in a way so it uses the code in the repo (instead of downloading from the Terraform Registry) but kept hitting issues. The above is good enough for now I think. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 378 insertions(+), 175 deletions(-)) |
Tests analyticsTotal tests:
|
…oogleCloudPlatform#8943) * Uncomment test cases for unknown values * Update test case names * Update unknown value test for `project`, make it pass * Update unknown value test for `access_token`, make `access_token` and `credentials` tests pass * Update unknown value tests for `region` and `zone`, make those tests pass * Update unknown value tests for `user_project_override`, make that test pass * Update unknown value test for `impersonate_service_account`, make that test pass * Update unknown value tests for `request_reason` and `request_timeout`, make those tests pass * Make unknown batching.send_after and batching.enable_batching values be set to same defaults as if they were null, update test * Update code to handle when the whole batching block is Unknown * Update the test function for `batching` unit tests to navigate how `GetBatchingConfig` is used by the code * Update code to handle null/unknown Scopes and ImpersonateServiceAccountDelegates values * Improve `impersonate_service_account_delegates` tests for unknown values * Add missing null test case for `batching` field * Add non-VCR acceptance test to assert handling of unknown values in provider config Only testing `credentials` currently.
…oogleCloudPlatform#8943) * Uncomment test cases for unknown values * Update test case names * Update unknown value test for `project`, make it pass * Update unknown value test for `access_token`, make `access_token` and `credentials` tests pass * Update unknown value tests for `region` and `zone`, make those tests pass * Update unknown value tests for `user_project_override`, make that test pass * Update unknown value test for `impersonate_service_account`, make that test pass * Update unknown value tests for `request_reason` and `request_timeout`, make those tests pass * Make unknown batching.send_after and batching.enable_batching values be set to same defaults as if they were null, update test * Update code to handle when the whole batching block is Unknown * Update the test function for `batching` unit tests to navigate how `GetBatchingConfig` is used by the code * Update code to handle null/unknown Scopes and ImpersonateServiceAccountDelegates values * Improve `impersonate_service_account_delegates` tests for unknown values * Add missing null test case for `batching` field * Add non-VCR acceptance test to assert handling of unknown values in provider config Only testing `credentials` currently.
Fixes hashicorp/terraform-provider-google#14444
Related to #8798
Release Note Template for Downstream PRs (will be copied)