Skip to content

Initial split of diff computation from breaking change computation#8930

Merged
melinath merged 8 commits into
mainfrom
b-295223615
Sep 20, 2023
Merged

Initial split of diff computation from breaking change computation#8930
melinath merged 8 commits into
mainfrom
b-295223615

Conversation

@melinath

@melinath melinath commented Sep 12, 2023

Copy link
Copy Markdown
Member

fixes b/295223615

I tried to keep this as small as possible but it ended up much larger than I expected. However, most of the length is test cases.

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 44 deletions(-))
Terraform Beta: Diff ( 2 files changed, 44 deletions(-))
TF Conversion: Diff ( 1 file changed, 17 deletions(-))

@modular-magician

This comment was marked as outdated.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field annotations within resource google_alloydb_instance was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 44 deletions(-))
Terraform Beta: Diff ( 2 files changed, 44 deletions(-))
TF Conversion: Diff ( 1 file changed, 17 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3037
Passed tests 2733
Skipped tests: 297
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccGKEHub2ScopeIamBindingGenerated|TestAccGKEHub2Scope_gkehubScopeBasicExample|TestAccGKEHub2ScopeIamMemberGenerated|TestAccGKEHub2ScopeIamPolicyGenerated

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccGKEHub2ScopeIamBindingGenerated[Debug log]
TestAccGKEHub2Scope_gkehubScopeBasicExample[Debug log]
TestAccGKEHub2ScopeIamMemberGenerated[Debug log]
TestAccGKEHub2ScopeIamPolicyGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Comment thread tools/diff-processor/rules/rules_field.go Outdated
Comment thread tools/diff-processor/diff/diff.go
Comment thread tools/diff-processor/diff/diff.go Outdated
Comment thread tools/diff-processor/diff/diff.go
Comment thread tools/diff-processor/diff/diff.go Outdated
Comment thread tools/diff-processor/diff/diff.go
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3045
Passed tests 2747
Skipped tests: 298
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Comment thread tools/diff-processor/rules/rules_field.go
@melinath melinath merged commit 53d0524 into main Sep 20, 2023
@melinath melinath deleted the b-295223615 branch September 20, 2023 22:59
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Sep 22, 2023
…oogleCloudPlatform#8930)

* Initial split of diff computation from breaking change computation

* Made a breaking change

* go mod tidy

* Fixed import path

* Corrected function diff detection

* Revert "Made a breaking change"

This reverts commit 0d4fd2b.

* Reverted detection of new required field addition

b/300515447

* Factored out key union logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants