feat(google_container_node_pool): support fast socket#8884
Conversation
|
Hello! I am a robot. It looks like you are a: Community Contributor @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
e156deb to
973d823
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 147 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_config {
fast_socket {
enabled = # value needed
}
}
node_pool {
node_config {
fast_socket {
enabled = # value needed
}
}
}
}
Resource: resource "google_container_node_pool" "primary" {
node_config {
fast_socket {
enabled = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerNodePool_fastSocket |
|
Rerun these tests in REPLAYING mode to catch issues
|
fix bad indent
973d823 to
fa27c35
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 147 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_config {
fast_socket {
enabled = # value needed
}
}
node_pool {
node_config {
fast_socket {
enabled = # value needed
}
}
}
}
Resource: resource "google_container_node_pool" "primary" {
node_config {
fast_socket {
enabled = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountIdToken_impersonation |
|
Rerun these tests in REPLAYING mode to catch issues
|
Fixes: hashicorp/terraform-provider-google#15715
This PR added support for fast socket field to
google_container_node_poolRelease Note Template for Downstream PRs (will be copied)