Skip to content

feat(google_container_node_pool): support fast socket#8884

Merged
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
rlia:add-support-for-fastsocket
Sep 15, 2023
Merged

feat(google_container_node_pool): support fast socket#8884
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
rlia:add-support-for-fastsocket

Conversation

@rlia

@rlia rlia commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Fixes: hashicorp/terraform-provider-google#15715
This PR added support for fast socket field to google_container_node_pool

Release Note Template for Downstream PRs (will be copied)

container: added `node_config.fast_socket` field to `google_container_node_pool`

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 7, 2023
@rlia rlia force-pushed the add-support-for-fastsocket branch from e156deb to 973d823 Compare September 7, 2023 12:13
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 7, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 147 insertions(+))
Terraform Beta: Diff ( 4 files changed, 147 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (235 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    fast_socket {
      enabled = # value needed
    }
  }
  node_pool {
    node_config {
      fast_socket {
        enabled = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (54 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    fast_socket {
      enabled = # value needed
    }
  }
}

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3018
Passed tests 2720
Skipped tests: 297
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerNodePool_fastSocket

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_fastSocket[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@rlia rlia force-pushed the add-support-for-fastsocket branch from 973d823 to fa27c35 Compare September 8, 2023 02:44
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 8, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 147 insertions(+))
Terraform Beta: Diff ( 4 files changed, 147 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (235 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    fast_socket {
      enabled = # value needed
    }
  }
  node_pool {
    node_config {
      fast_socket {
        enabled = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (54 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    fast_socket {
      enabled = # value needed
    }
  }
}

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3021
Passed tests 2723
Skipped tests: 297
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@shuyama1 shuyama1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for FastSocket in GKE node pools

3 participants