Upgrade DCL to v1.51.0#8876
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change Detection FailedThe breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer. Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 9 files changed, 220 insertions(+), 11 deletions(-)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 10 files changed, 221 insertions(+), 12 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_aws_node_pool" "primary" {
management {
auto_repair = # value needed
}
}
Resource: resource "google_container_azure_node_pool" "primary" {
management {
auto_repair = # value needed
}
}
Resource: resource "google_network_connectivity_spoke" "primary" {
linked_vpc_network {
exclude_export_ranges = # value needed
uri = # value needed
}
}
|
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccContainerAwsNodePool_BasicEnumHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicEnumHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 10 files changed, 221 insertions(+), 12 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_aws_node_pool" "primary" {
management {
auto_repair = # value needed
}
}
Resource: resource "google_container_azure_node_pool" "primary" {
management {
auto_repair = # value needed
}
}
Resource: resource "google_network_connectivity_spoke" "primary" {
linked_vpc_network {
exclude_export_ranges = # value needed
uri = # value needed
}
}
|
Tests analyticsTotal tests:
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 12 files changed, 245 insertions(+), 12 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_connectivity_spoke" "primary" {
linked_vpc_network {
exclude_export_ranges = # value needed
uri = # value needed
}
}
|
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccSpannerDatabaseIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 12 files changed, 245 insertions(+), 12 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_connectivity_spoke" "primary" {
linked_vpc_network {
exclude_export_ranges = # value needed
uri = # value needed
}
}
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 381 insertions(+), 12 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten|TestAccDataSourceGoogleServiceAccountJwt|TestAccProjectIamPolicy_invalidMembers |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 386 insertions(+), 12 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten|TestAccSpannerDatabaseIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 386 insertions(+), 12 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccContainerAzureNodePool_BetaBasicHandWritten|TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten |
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change Detection FailedThe breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer. Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 15 files changed, 421 insertions(+), 12 deletions(-)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change Detection FailedThe breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer. Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 15 files changed, 424 insertions(+), 12 deletions(-)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 15 files changed, 427 insertions(+), 12 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicEnumHandWritten|TestAccContainerAwsNodePool_BasicEnumHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccContainerAzureNodePool_BetaBasicHandWritten |
|
Rerun these tests in REPLAYING mode to catch issues
|
…mputed to avoid complications with the flattener
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 15 files changed, 435 insertions(+), 16 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAzureNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccDataSourceGoogleServiceAccountJwt |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 15 files changed, 443 insertions(+), 22 deletions(-)) |
Tests analyticsTotal tests:
|
|
@NickElliot we made config.instance_type updatable too, I think, looking at the generated diffs! Someone pinged me about their change so I was looking at this. Can you write an upgrade entry for that, and work with the next release shepherd (@trodge I think) to include it in the release? |
|
My bad! Do I need to just edit it into the original post here, or send it over to @trodge for manually updating the release notes? |
|
you'll need to send it over to @trodge - release notes don't pick up changes after merge. You may also want to modify the eventarc line to focus more on customer impact of the switch to O+C. Something like: |
|
You could theoretically edit the PR's changelog file in both repos to update the changelog generator (https://github.com/hashicorp/terraform-provider-google/blob/main/.changelog/8876.txt / https://github.com/hashicorp/terraform-provider-google-beta/blob/main/.changelog/8876.txt). But since we haven't done this before you'll still want to manually verify the changes worked (I'm also not sure if edits made after the cut date but before the cut is made would work- not an issue in this case, but possibly in others) |
5 participants
Release Note Template for Downstream PRs (will be copied)