Skip to content

Add upgrade notes for accesscontextmanager resource breaking changes#8864

Merged
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
Charlesleonius:patch-15
Sep 6, 2023
Merged

Add upgrade notes for accesscontextmanager resource breaking changes#8864
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
Charlesleonius:patch-15

Conversation

@Charlesleonius

@Charlesleonius Charlesleonius commented Sep 5, 2023

Copy link
Copy Markdown
Member

Changes added via #8788

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 53 insertions(+))
Terraform Beta: Diff ( 1 file changed, 53 insertions(+))

@c2thorn c2thorn requested review from shuyama1 and removed request for c2thorn September 6, 2023 15:21

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but assigning @shuyama1 to confirm as the reviewer for the main PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants