Skip to content

add google_logging_metric to version 5 upgrade doc for #8780#8836

Closed
pengq-google wants to merge 8 commits into
GoogleCloudPlatform:mainfrom
pengq-google:b5
Closed

add google_logging_metric to version 5 upgrade doc for #8780#8836
pengq-google wants to merge 8 commits into
GoogleCloudPlatform:mainfrom
pengq-google:b5

Conversation

@pengq-google

@pengq-google pengq-google commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@pengq-google

Copy link
Copy Markdown
Contributor Author

@c2thorn This is the major release doc change for #8780
Thanks for your help along the way!

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 14 insertions(+))
Terraform Beta: Diff ( 1 file changed, 14 insertions(+))

@SarahFrench SarahFrench requested review from c2thorn and removed request for SarahFrench September 1, 2023 12:25
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
pengq-google and others added 3 commits September 6, 2023 11:20
…de.html.markdown

Co-authored-by: Cameron Thornton <camthornton@google.com>
…de.html.markdown

Co-authored-by: Cameron Thornton <camthornton@google.com>
…de.html.markdown

Co-authored-by: Cameron Thornton <camthornton@google.com>
@c2thorn

c2thorn commented Sep 6, 2023

Copy link
Copy Markdown
Member

I believe this has failed because there are now conflicts @pengq-google

@pengq-google

Copy link
Copy Markdown
Contributor Author

replaced by #8886

@pengq-google pengq-google deleted the b5 branch October 26, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants