Transfer tgc/cai2hcl ownership to magic-modules

[amirkaromashkin]

This change moves tgc/cai2hcl management to magic-modules/mmv1 using new provider, which will then be used for generated cai2hcl converters.

terraform-google-conversion/cai2hcl folder is now managed from GCP/magic-modules

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

[modular-magician]

Tests analytics

Total tests: 3008
Passed tests 2712
Skipped tests: 296
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 24 files changed, 801 insertions(+), 272 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3008
Passed tests 2709
Skipped tests: 296
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocJobIamPolicy|TestAccHealthcareDatasetIamPolicy|TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]
TestAccHealthcareDatasetIamPolicy[Debug log]
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[roaks3]

@amirkaromashkin I'm a little surprised by this change, but I may be missing context. Do you have an internal issue tracking this work, or have you been working with a member of our team on this?

[melinath]

@roaks3 I've been talking with Amir about this change - this PR should make MM take over management of cai2hcl with no diffs - other changes would ideally be in other PRs (but I believe some of these changes were necessary here as part of bringing the files under managment.)

[roaks3]

Ok, got it, and I reviewed the internal doc. I took a first pass and things looked good, but to help with review, am I correct in assuming that mmv1/third_party/cai2hcl files are copied verbatim from somewhere?

[amirkaromashkin]

Ok, got it, and I reviewed the internal doc. I took a first pass and things looked good, but to help with review, am I correct in assuming that mmv1/third_party/cai2hcl files are copied verbatim from somewhere?

Its not completely verbatim. Its a slightly refactored version of https://github.com/GoogleCloudPlatform/terraform-google-conversion/tree/main/cai2hcl: converters themselves were not changed, I changed packages/folder structure and helper methods like convert.go.

Testdata files copied from https://github.com/GoogleCloudPlatform/terraform-google-conversion/tree/main/testdata as is.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 23 files changed, 709 insertions(+), 219 deletions(-))

[edisonhuang-google]

LGTM

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 22 files changed, 667 insertions(+), 177 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3020
Passed tests 2723
Skipped tests: 297
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[roaks3]

I just tried to take another look here and this is very hard to review with the assumption that everything is newly written (you mentioned that some refactoring happened). Could you please provide some more context on what was changed (and perhaps why)? Where should I be looking for changes to the previous behavior vs. parts that are copy-and-pasted?

[amirkaromashkin]

I just tried to take another look here and this is very hard to review with the assumption that everything is newly written (you mentioned that some refactoring happened). Could you please provide some more context on what was changed (and perhaps why)? Where should I be looking for changes to the previous behavior vs. parts that are copy-and-pasted?

I guess there are 2 ways to handle it:

1. I give the broad explanation of all the changes and refactoring I made to the https://github.com/GoogleCloudPlatform/terraform-google-conversion/tree/main/cai2hcl
2. I first manually update the target repo, get it merged and then this migration will be verbatim (I'll need to give explanations there, but this will be less complicated)

I guess the 2nd option looks better. WDYT? @roaks3

[amirkaromashkin]

I just tried to take another look here and this is very hard to review with the assumption that everything is newly written (you mentioned that some refactoring happened). Could you please provide some more context on what was changed (and perhaps why)? Where should I be looking for changes to the previous behavior vs. parts that are copy-and-pasted?

I guess there are 2 ways to handle it:

1. I give the broad explanation of all the changes and refactoring I made to the https://github.com/GoogleCloudPlatform/terraform-google-conversion/tree/main/cai2hcl
2. I first manually update the target repo, get it merged and then this migration will be verbatim (I'll need to give explanations there, but this will be less complicated)

I guess the 2nd option looks better. WDYT? @roaks3

I have just found a slight bug in a folder structure when started to implement the Option2. So I believe its a better approach. On it.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 22 files changed, 667 insertions(+), 177 deletions(-))

[roaks3]

Yea, I think the second option would be ideal here. Thanks!

[roaks3]

Passing over to @melinath as I will likely be on PTO when this is ready for another look

[melinath]

GoogleCloudPlatform/terraform-google-conversion#1416 is the PR to refactor TGC first.

[melinath]

Refactor of TGC is complete - marking this as reviewed pending updates to match the final structure we settled on.

[amirkaromashkin]

Refactor of TGC is complete - marking this as reviewed pending updates to match the final structure we settled on.

Done. Now it should produce zero diff

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

[modular-magician]

Tests analytics

Total tests: 3077
Passed tests 2778
Skipped tests: 299
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[melinath]

LGTM