Skip to content

update version_5_upgrade.html.markdown for provider Zone and Region V…#8807

Closed
BBBmau wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
BBBmau:update-version5-guide
Closed

update version_5_upgrade.html.markdown for provider Zone and Region V…#8807
BBBmau wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
BBBmau:update-version5-guide

Conversation

@BBBmau

@BBBmau BBBmau commented Aug 30, 2023

Copy link
Copy Markdown
Collaborator

…alues

References this PR #8587

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 30, 2023
@NickElliot NickElliot requested review from SarahFrench and removed request for NickElliot August 30, 2023 21:03

@SarahFrench SarahFrench left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l left a few bits of feedback around the theme of writing this guide with users as our intended audience. Overall, I think writing this addition to the guide is tough as someone new to the Google provider, so thank you for preparing this draft! 😁

Next week we can get some more eyes on this PR from the Google team to help figure out how much detail to include.

Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
@SarahFrench

Copy link
Copy Markdown
Contributor

Superseded by #9008

(I've put us as co-committers there!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants