Remove Terraform support for game services#8669
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 25 files changed, 2 insertions(+), 4229 deletions(-)) |
Tests analyticsTotal tests:
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 25 files changed, 2 insertions(+), 4230 deletions(-)) |
Tests analyticsTotal tests:
|
|
google-conversion is failing... are we expecting it to here? I can't see the line in the generated diff |
|
Is there an upgrade guide entry PR? |
(#8693) |
I need to double-check a bit, maybe there's something I missed during the removal. Thanks for highlighting the error. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 26 files changed, 7 insertions(+), 4230 deletions(-)) |
Tests analyticsTotal tests:
|
c2thorn
left a comment
There was a problem hiding this comment.
added the label, don't remember if we need it for this branch.
Remove Terraform support for game services.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)