Skip to content

Add guides for labels and annotations#8608

Merged
zli82016 merged 7 commits into
mainfrom
labels-guide
Aug 16, 2023
Merged

Add guides for labels and annotations#8608
zli82016 merged 7 commits into
mainfrom
labels-guide

Conversation

@zli82016

Copy link
Copy Markdown
Member

Add the introduction to the new labels and annotations models and will add more details later.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 18 insertions(+))
Terraform Beta: Diff ( 1 file changed, 18 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 22 insertions(+))
Terraform Beta: Diff ( 1 file changed, 22 insertions(+))

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a provider-level change, so please but it slightly lower in the

Provider section

You can then remove the example where it says "Provider-level change example header"

Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 30 insertions(+))
Terraform Beta: Diff ( 1 file changed, 30 insertions(+))

@zli82016

Copy link
Copy Markdown
Member Author

Thanks so much for the comments.

@zli82016 zli82016 requested a review from c2thorn August 10, 2023 22:37
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 30 insertions(+))
Terraform Beta: Diff ( 1 file changed, 30 insertions(+))

Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Section looks much better, thank you for adding clarifications! Can we move the entire section below the ## Provider line on line 119? Then delete the

Provider-level change example header

Description of the change and how users should adjust their configuration (if needed).

lines?

Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
@zli82016

Copy link
Copy Markdown
Member Author

Section looks much better, thank you for adding clarifications! Can we move the entire section below the ## Provider line on line 119? Then delete the

Provider-level change example header

Description of the change and how users should adjust their configuration (if needed).

lines?

Done.

@zli82016 zli82016 requested a review from c2thorn August 11, 2023 20:31
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 28 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 28 insertions(+), 2 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 28 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 28 insertions(+), 2 deletions(-))

@zli82016 zli82016 merged commit dfaa675 into main Aug 16, 2023
@zli82016 zli82016 deleted the labels-guide branch August 16, 2023 21:02
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
* Add guides for labels and annotations

* Modify the guides

* Modify the guide

* Modify the guide

* Modify the guide

* Add more spaces

* Move 'Provider-level Labels Rework' below Provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants