Add guides for labels and annotations#8608
Conversation
c2thorn
left a comment
There was a problem hiding this comment.
This is a provider-level change, so please but it slightly lower in the
Provider section
You can then remove the example where it says "Provider-level change example header"
|
Thanks so much for the comments. |
c2thorn
left a comment
There was a problem hiding this comment.
Section looks much better, thank you for adding clarifications! Can we move the entire section below the ## Provider line on line 119? Then delete the
Provider-level change example header
Description of the change and how users should adjust their configuration (if needed).
lines?
Done. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 28 insertions(+), 2 deletions(-)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 28 insertions(+), 2 deletions(-)) |
* Add guides for labels and annotations * Modify the guides * Modify the guide * Modify the guide * Modify the guide * Add more spaces * Move 'Provider-level Labels Rework' below Provider
Add the introduction to the new labels and annotations models and will add more details later.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)