Skip to content

Revert "Skip *_BetaBasicHandWritten tests that are consistently faili…#8577

Merged
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
ostrain:revert-test-skip
Aug 8, 2023
Merged

Revert "Skip *_BetaBasicHandWritten tests that are consistently faili…#8577
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
ostrain:revert-test-skip

Conversation

@ostrain

@ostrain ostrain commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Revert "Skip *_BetaBasicHandWritten tests that are consistently failing (#8476)"

This reverts commit 2a0393a.

The underlying issue (hashicorp/terraform-provider-google#14085) has been fixed so we can revert this now.

Closes hashicorp/terraform-provider-google#14085

@modular-magician

Copy link
Copy Markdown
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform Beta: Diff ( 3 files changed, 881 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2939
Passed tests 2636
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}
View the build log or the debug log for each test

@zli82016

zli82016 commented Aug 8, 2023

Copy link
Copy Markdown
Member

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccContainer*NodePool_BetaBasicHandWritten (beta)

3 participants