Remove tgc build from downstream builder by trodge · Pull Request #8472 · GoogleCloudPlatform/magic-modules

trodge · 2023-07-27T20:17:00Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

trodge · 2023-07-27T20:41:00Z

/gcbrun

trodge · 2023-07-27T22:29:16Z

/gcbrun

ScottSuarez · 2023-07-27T22:38:10Z

/gcbrun

ScottSuarez · 2023-07-28T18:11:35Z

-    pushd $LOCAL_PATH
-
-    if [ "$COMMAND" == "downstream" ]; then
-      go get -d github.com/hashicorp/terraform-provider-google-beta@$BASE_BRANCH


This line will need to stay, otherwise the downstream branch won't update terraform-provider-google-beta to latest in the go.sum

ScottSuarez · 2023-07-28T18:15:53Z

Thankfully we probably can retain the old behavior. For the push_downstream build

magic-modules/.ci/gcb-push-downstream.yml

Lines 107 to 130 in 07720f6

    
               - name: 'gcr.io/graphite-docker-images/downstream-builder' 
        
                 secretEnv: ["GITHUB_TOKEN"] 
        
                 id: tgc-push 
        
                 waitFor: ["tgc-sync", "tpg-push"] 
        
                 env: 
        
                   - BASE_BRANCH=$BRANCH_NAME 
        
                 args: 
        
                     - 'downstream' 
        
                     - 'terraform-google-conversion' 
        
                     - 'beta' 
        
                     - $COMMIT_SHA 
        
               - name: 'gcr.io/cloud-builders/git' 
        
                 waitFor: ["tgc-push"] 
        
                 secretEnv: ["GITHUB_TOKEN"] 
        
                 entrypoint: 'bash' 
        
                 args: 
        
                     - -c 
        
                     - | 
        
                       if [ "$BRANCH_NAME" == "main" ]; then 
        
                         git push https://modular-magician:$$GITHUB_TOKEN@github.com/GoogleCloudPlatform/magic-modules $COMMIT_SHA:tgc-sync 
        
                       else  
        
                         git push https://modular-magician:$$GITHUB_TOKEN@github.com/GoogleCloudPlatform/magic-modules $COMMIT_SHA:tgc-sync-$BRANCH_NAME 
        
                       fi

Looks like this is where the downstreams are built. We need to update the wait_for to be dependent on tpgb

magic-modules/.ci/gcb-push-downstream.yml

Line 110 in 07720f6

waitFor: ["tgc-sync", "tpg-push"]

modular-magician · 2023-07-28T18:17:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

trodge · 2023-07-28T18:24:04Z

If we're retaining the old behavior doesn't it already wait on everything it needs to wait on?

ScottSuarez · 2023-07-28T18:57:49Z

we changed it to rely on tpgb but this line was never updated. I think its a mishap.

modular-magician · 2023-07-28T19:35:07Z

Tests analytics

Total tests: 2908
Passed tests 2604
Skipped tests: 302
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample

Get to know how VCR tests work

modular-magician · 2023-07-28T19:36:53Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-07-28T20:33:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician · 2023-07-28T22:07:10Z

Tests analytics

Total tests: 2909
Passed tests 2606
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

modular-magician · 2023-07-28T22:07:46Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

ScottSuarez · 2023-07-28T22:12:44Z

Looks like all the terraform google conversion tests are failing status on the PR

ScottSuarez · 2023-07-28T22:18:25Z

Ah this is probably because you didn't update their container. Could you also update their containers remotely. Want to make sure everything is green before landing it.

modular-magician · 2023-08-03T20:48:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician · 2023-08-04T19:38:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 1 file changed, 1 insertion(+))

ScottSuarez · 2023-08-04T20:06:09Z

Looks good !! Thanks so much, one last flow I would like to see. Could you make a small change to tgc so the code compiles and tests run without being skipped. Then I think we are good to check this in !

modular-magician · 2023-08-04T20:55:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 1 file changed, 2 insertions(+))

ScottSuarez

Looks good to me. Could you revert the changes to the mmv1 directory. Thanks for testing!!

trodge force-pushed the ci-changes branch from f0b1b38 to f631a53 Compare July 27, 2023 20:45

ScottSuarez reviewed Jul 28, 2023

View reviewed changes

trodge requested a review from ScottSuarez July 28, 2023 20:21

trodge force-pushed the ci-changes branch from ffefce4 to e0c0f24 Compare August 3, 2023 20:41

ScottSuarez requested changes Aug 4, 2023

View reviewed changes

Comment thread .ci/scripts/go-plus/terraform-validator-tester/test_terraform_validator.sh

Remove tgc build from downstream builder

53b915d

trodge force-pushed the ci-changes branch from 221f089 to 19358da Compare August 4, 2023 20:47

ScottSuarez approved these changes Aug 4, 2023

View reviewed changes

trodge force-pushed the ci-changes branch from 19358da to 53b915d Compare August 4, 2023 21:32

trodge merged commit bcc8c94 into GoogleCloudPlatform:main Aug 4, 2023

trodge deleted the ci-changes branch August 4, 2023 21:33

jeperetz pushed a commit to jeperetz/magic-modules that referenced this pull request Aug 10, 2023

Remove tgc build from downstream builder (GoogleCloudPlatform#8472)

4d32e93

Uh oh!

Conversation

trodge commented Jul 27, 2023

Uh oh!

trodge commented Jul 27, 2023

Uh oh!

trodge commented Jul 27, 2023

Uh oh!

ScottSuarez commented Jul 27, 2023

Uh oh!

ScottSuarez Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

ScottSuarez commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Jul 28, 2023

Diff report

Uh oh!

trodge commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ScottSuarez commented Jul 28, 2023

Uh oh!

modular-magician commented Jul 28, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jul 28, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

modular-magician commented Jul 28, 2023

Diff report

Uh oh!

modular-magician commented Jul 28, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jul 28, 2023

Uh oh!

ScottSuarez commented Jul 28, 2023

Uh oh!

ScottSuarez commented Jul 28, 2023

Uh oh!

modular-magician commented Aug 3, 2023

Diff report

Uh oh!

Uh oh!

modular-magician commented Aug 4, 2023

Diff report

Uh oh!

ScottSuarez commented Aug 4, 2023

Uh oh!

modular-magician commented Aug 4, 2023

Diff report

Uh oh!

ScottSuarez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ScottSuarez commented Jul 28, 2023 •

edited

Loading

trodge commented Jul 28, 2023 •

edited

Loading