Adding TF support for Tenancy APIs for Membership RBAC Role Bindings#8440
Conversation
|
Hello! I am a robot. It looks like you are a community contributor. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 876 insertions(+), 2 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
…hings simpler in the review
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 750 insertions(+), 2 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_membership_rbac_role_binding" "primary" {
location = # value needed
membership_id = # value needed
membership_rbac_role_binding_id = # value needed
role {
predefined_role = # value needed
}
user = # value needed
}
|
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccDataSourceGoogleServiceAccountJwt |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 754 insertions(+), 2 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_membership_rbac_role_binding" "primary" {
location = # value needed
membership_id = # value needed
membership_rbac_role_binding_id = # value needed
role {
predefined_role = # value needed
}
user = # value needed
}
|
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
ScottSuarez
left a comment
There was a problem hiding this comment.
Could you pull the latest changes from main?
Looks like there are some failures in the testing pipeline due to an old base
…leCloudPlatform#8470) * Allow specifying global L7 ILB in dns_record_set routing policy * fix url_map default_service in docs * fix forwarding rule reference in rrset for cross-region test * don't specify region for globalL7ilb routing policy item * add backend subnet for FR IP address provisioning * pass backendSubnetName to cross-region L7 test case * remove google-beta req from test backend subnet * remove extra primary-backup examples * add globalL7ilb value to docs
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 754 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccServiceAccountIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Notice: it appears this resource is |
…oogleCloudPlatform#8440) Co-authored-by: hkundag <53873858+hkundag@users.noreply.github.com>
Fixes hashicorp/terraform-provider-google#15167
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)