Tries to fix a flaky test#8438
Conversation
|
Hello! I am a robot. It looks like you are a community contributor. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 10 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
|
Rerun these tests in REPLAYING mode to catch issues
|
slevenick
left a comment
There was a problem hiding this comment.
Looks reasonable to me!
* add depends_on * change depends_on value
* add depends_on * change depends_on value
* add depends_on * change depends_on value
* add depends_on * change depends_on value
Fixes hashicorp/terraform-provider-google#15088.
Per the suggestion from this comment, add depends on to the cloud run job resource.
Release Note Template for Downstream PRs (will be copied)