making sure swp can be created without scope and certificateUrls

[felipegc]

Fixes:
hashicorp/terraform-provider-google#15223

Making sure SWP can be provisioned without scope and certificateUrl fields

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

network_services: removing required flags from `scope` field in `google_network_services_gateway` resource

[modular-magician]

Hello! I am a robot. It looks like you are a community contributor. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 99 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 3 files changed, 99 insertions(+), 16 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2872
Passed tests 2570
Skipped tests: 299
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_minimalSwp|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkServicesGateway_minimalSwp[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[NickElliot]

From reviewing when the update was made to the API (cl/509281977), it seems scope should also have its "immutable" status removed. There is API end validation to prevent users from updating OPEN_MESH gateways, and it is expected users can update Scope for SECURE_WEB_GATEWAYs.

[NickElliot]

Sorry to ask for another change, but with the immutable status being removed could you uncomment the update test for SECURE_WEB_GATEWAYs that actually already exists here, and add a "newGatewayScope" variable to use in the second case. Thanks!

[felipegc]

Sorry to ask for another change, but with the immutable status being removed could you uncomment the update test for SECURE_WEB_GATEWAYs that actually already exists here, and add a "newGatewayScope" variable to use in the second case. Thanks!

I have double checked if scope field is updatable and the api returns an error so I put the immutable flag back to it.
I have created the task you mentioned because there is a plan where "certificateUrls" and "policy" will be updatable in the future. This commented test is addressed for testing that.

[NickElliot]

LGTM then!