chore: remove unused doc region tags#8321
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @trodge, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 1 insertion(+), 34 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
|
|
Changes did not touch these tests. |
|
@trodge Do you know why this didn't propagate to docs-examples? I need to remove tags from that repo as well, see terraform-google-modules/docs-examples#467 |
The samples linked in official documentation have been migrated to https://github.com/terraform-google-modules/terraform-docs-samples. These samples are automatically "copied" into other repos like GoogleCloudPlatform/k8s-config-connector, hashicorp/terraform-provider-google-beta, and hashicorp/terraform-provider-google. The copying of the region tags makes conflicts in DevRel services and inappropriately shows examples embedded in Go test code.
I have checked that there are no doc references to magic-modules, hashicorp/terraform-provider-google-beta, or hashicorp/terraform-provider-google
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)