Corrected GOOGLE_USE_DEFAULT_CREDENTIALS value

[melinath]

true needs to be lowercase.
yaqs/1353904533582905344

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[rileykarson]

Can you test this? On my machine:

GOOGLE_USE_DEFAULT_CREDENTIALS=TRUE

[melinath]

@rileykarson can confirm that if I set GOOGLE_USE_DEFAULT_CREDENTIALS=TRUE when running tests for TestAccPubsubTopic_ I get the following error for TestAccPubsubTopic_cmek specifically:

bootstrap_test_utils.go:603: Bootstrapping failed. Unable to load test config: unable to parse credentials from 'TRUE': invalid character 'T' looking for beginning of value

The other tests do still pass.

Note: This case will only be hit if all other env vars in CredsEnvVars are empty (or set to true). And apparently also only if a bootstrapped resource is used in the test? I'm a little surprised by that tbh - I would've thought this was used in all tests.

[melinath]

It looks like this would probably also impact sweepers and tests of the Config object (but again only if the other related vars are unset.)

[rileykarson]

Ah- yeah, I see it when using a test that requires bootstrapping. Seems to be a bug in those, weird.

[modular-magician]

Tests analytics

Total tests: 2852
Passed tests 2554
Skipped tests: 296
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test