Skip to content

Add forward/review label #8313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trodge merged 2 commits into from
Jul 11, 2023
Merged

Add forward/review label #8313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f080908
Add forward/review label
trodge Jul 11, 2023
6bf166f
Update enrolled teams yaml
trodge Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions tools/issue-labeler/enrolled_teams.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ services/bigquery:
- google_bigquery_
services/bigtableadmin:
- google_bigtable_
services/billingbudgets:
- google_billing_budget
services/certificatemanager:
- google_certificate_manager_
services/cloudbilling:
- google_billing_account
- google_billing_subaccount
services/cloudbuild:
- google_cloudbuild_
- google_cloudbuildv2_
Expand All @@ -30,6 +37,13 @@ services/composer:
- google_composer_
services/compute-nat:
- google_compute_router_nat
services/compute-regional-l7-load-balancer:
- google_compute_region_target_http_proxy
- google_compute_region_target_https_proxy
services/container:
- google_container_cluster
- google_container_engine_versions
- google_container_node_pool
services/dataproc:
- google_dataproc_cluster
- google_dataproc_autoscaling_policy
Expand All @@ -38,6 +52,8 @@ services/dataproc:
- google_dataproc_batch
services/dlp:
- google_data_loss_prevention_
services/edgenetwork:
- google_edgenetwork_
services/eventarc:
- google_eventarc_
services/filestore:
Expand All @@ -55,8 +71,14 @@ services/gkebackup:
- google_gke_backup_
services/gkehub:
- google_gke_hub_
services/gkemulticloud:
- google_container_aws_
- google_container_azure_
- google_container_attached_
services/gkeonprem:
- google_gkeonprem_
services/healthcare:
- google_healthcare_
services/iam-core:
- google_organization_iam_custom_role
- google_project_iam_custom_role
Expand Down Expand Up @@ -94,6 +116,10 @@ services/orgpolicy:
- google_org_policy_
services/privateca:
- google_privateca_
services/pubsublite:
- google_pubsub_lite_
services/redis-instance:
- google_redis_instance
services/run:
- google_cloud_run_
- google_cloud_run_v2_
Expand Down
1 change: 1 addition & 0 deletions tools/issue-labeler/labels.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ func labels(issueBody string, enrolledTeams map[string][]string) string {
}

if len(labels) > 0 {
labels = append(labels, "\"forward/review\"")
sort.Strings(labels)
return "[" + strings.Join(labels, ", ") + "]"
}
Expand Down
2 changes: 1 addition & 1 deletion tools/issue-labeler/labels_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func TestLabels(t *testing.T) {
google_gke_hub_feature
google_storage_hmac_key
#`,
expectedLabels: `["services/gkehub", "services/storage"]`,
expectedLabels: `["forward/review", "services/gkehub", "services/storage"]`,
},
{
issueBody: `### New or Affected Resource(s):
Expand Down