Skip to content

fix VCR#8295

Merged
shuyama1 merged 3 commits into
GoogleCloudPlatform:mainfrom
shuyama1:VCR_upgrade
Jul 10, 2023
Merged

fix VCR#8295
shuyama1 merged 3 commits into
GoogleCloudPlatform:mainfrom
shuyama1:VCR_upgrade

Conversation

@shuyama1

@shuyama1 shuyama1 commented Jul 9, 2023

Copy link
Copy Markdown
Member

This PR will:

  • fix OOM issue in recording after running tests in subfolders
  • re-enable replaying rerun
  • fix VCR error code
  • highlight test failures/error in test report

Image has already been built and uploaded. This change is tested in #8294

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@shuyama1
shuyama1 requested a review from zli82016 July 10, 2023 02:49

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@shuyama1
shuyama1 merged commit 2a680b6 into GoogleCloudPlatform:main Jul 10, 2023
@shuyama1
shuyama1 deleted the VCR_upgrade branch July 10, 2023 17:32
baskaran-md pushed a commit to baskaran-md/magic-modules that referenced this pull request Jul 10, 2023
Khaledmohamedrefaat pushed a commit to Khaledmohamedrefaat/magic-modules that referenced this pull request Jul 13, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants