fix import error for orgpolicy#8291
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @NickElliot, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 5 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
|
Tests failed during RECORDING mode: Please fix these to complete your PR |
NickElliot
left a comment
There was a problem hiding this comment.
LGTM with minor note edit, to @hao-nan-li for final approval
Unrelated test failures.
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Fixes hashicorp/terraform-provider-google#15070
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)