Added Edition field in settings block of sql_database_instance#8277
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @zli82016, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 103 insertions(+), 49 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
Tests analyticsTotal tests: Action takenFound 107 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSqlDatabaseInstance_maintenanceVersion|TestAccSqlDatabaseInstance_activationPolicy|TestAccSqlUser_postgresAbandon|TestAccSqlDatabaseInstance_ReplicaPromoteSkippedWithNoMasterInstanceNameAndNoReplicaConfigurationPresent|TestAccSqlUser_postgres|TestAccSqlClientCert_postgres|TestAccSqlDatabase_basic|TestAccSqlDatabase_update|TestAccSqlClientCert_mysql|TestAccSqlUser_postgresIAM|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNameAndReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNamePresent|TestAccSqlDatabaseInstance_ReplicaPromoteSuccessful|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_basicMSSQL|TestAccSqlDatabaseInstance_basicSecondGen|TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample|TestAccSQLDatabase_sqlDatabaseBasicExample|TestAccDataSourceSqlDatabases_basic|TestAccDataSourceSqlDatabase_basic|TestAccDataSourceSqlDatabaseInstances_tierFilter|TestAccDataSourceSqlDatabaseInstances_regionFilter|TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip|TestAccComputeRegionInstanceTemplate_guestAccelerator|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeRegionInstanceTemplate_primaryAliasIpRange|TestAccComputeRegionInstanceTemplate_metadata_startup_script|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter|TestAccDataSourceSqlDatabaseInstances_basic|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_regionDisks|TestAccDataSourceSqlDatabaseInstance_basic|TestAccComputeRegionInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccComputeInstanceTemplate_withScratchDisk|TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccComputeInstanceTemplate_disks|TestAccContainerAwsCluster_BasicHandWritten|TestAccComputeRegionInstanceTemplate_with18TbScratchDisk|TestAccComputeRegionInstanceTemplate_withScratchDisk|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccComputeInstanceTemplate_NetworkAttachment|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccComputeFirewallPolicyRule_multipleRules|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccCloudbuildv2Connection_GleConnection|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccCloudRunV2Job_cloudrunv2JobSqlExample|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeInstanceFromTemplate_self_link_unique|TestAccComputeInstanceFromTemplate_basic|TestAccCloudbuildv2Connection_GleOldConnection|TestAccComputeInstanceTemplate_guestAccelerator|TestAccCloudbuildv2Connection_GitlabConnection|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_regionDisks|TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample|TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable|TestAccSQLDatabaseInstance_basicEdition|TestAccSqlDatabaseInstance_Timezone|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer|TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled|TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample|TestAccSqlDatabaseInstance_BackupRetention|TestAccSQLDatabaseInstance_DenyMaintenancePeriod|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_encryptionKey|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_diskspecs|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled|TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion|TestAccSqlDatabaseInstance_Smt|TestAccSqlDatabaseInstance_insights|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_maintenance |
|
Tests passed during RECORDING mode: Rerun these tests in REPLAYING mode to catch issuesTests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you do not know how VCR tests work, please work with the code reviewer to figure out the reason why the tests failed and fix the tests. Tests failed during RECORDING mode: Several tests got terminated during RECORDING mode. |
…one in sql_database_instance
Re-formatted code
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 263 insertions(+), 49 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 263 insertions(+), 49 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
Tests analyticsTotal tests: Action takenFound 65 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket|TestAccSqlUser_postgres|TestAccSqlDatabaseInstance_ReplicaPromoteSkippedWithNoMasterInstanceNameAndNoReplicaConfigurationPresent|TestAccSqlUser_postgresAbandon|TestAccSqlDatabase_update|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNameAndReplicaConfigurationPresent|TestAccSqlClientCert_mysql|TestAccSqlDatabase_basic|TestAccSqlClientCert_postgres|TestAccSqlUser_postgresIAM|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNamePresent|TestAccSqlDatabaseInstance_ReplicaPromoteSuccessful|TestAccSqlDatabaseInstance_activationPolicy|TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable|TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled|TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample|TestAccSqlDatabaseInstance_Timezone|TestAccSqlDatabaseInstance_Smt|TestAccDataSourceSqlDatabases_basic|TestAccDataSourceSqlDatabase_basic|TestAccDataSourceSqlDatabaseInstances_tierFilter|TestAccDataSourceSqlDatabaseInstances_regionFilter|TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample|TestAccDataSourceSqlDatabaseInstances_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccDataSourceSqlDatabaseInstance_basic|TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig|TestAccSqlDatabaseInstance_EnterpriseEdition|TestAccSqlDatabaseInstance_EnterprisePlusEdition|TestAccSQLDatabaseInstance_DenyMaintenancePeriod|TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_BackupRetention|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlDatabaseInstance_authNets|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_encryptionKey|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_maintenance|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_diskspecs|TestAccSqlDatabaseInstance_insights|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled|TestAccSqlDatabaseInstance_maintenanceVersion|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_basicMSSQL|TestAccSqlDatabaseInstance_basicSecondGen|TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample|TestAccSQLDatabase_sqlDatabaseBasicExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccCloudRunV2Job_cloudrunv2JobSqlExample|TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample |
|
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 263 insertions(+), 49 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
|
|
||
| func TestAccSqlDatabaseInstance_cloneWithPreferredZone(t *testing.T) { | ||
| // Sqladmin client | ||
| acctest.SkipIfVcr(t) |
There was a problem hiding this comment.
What is the reason to skip this test in Vcr?
There was a problem hiding this comment.
Every other tests related to Clone also skipped in Vcr. So i just followed them.
There was a problem hiding this comment.
Have you run this test locally to see if it passed?
There was a problem hiding this comment.
I run this test locally and got this error
Invalid request: The preferred zone field isn't supported for the local-mediator-361721:tf-bootstrap-f0ruwbstwx instance..
Do you know how to fix it? Thanks.
There was a problem hiding this comment.
This is the doc to run tests locally, in case you need it. https://googlecloudplatform.github.io/magic-modules/get-started/run-provider-tests/
There was a problem hiding this comment.
Dropped preferred_zone from this PR.
| PreCheck: func() { acctest.AccTestPreCheck(t) }, | ||
| ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t), | ||
| CheckDestroy: testAccSqlDatabaseInstanceDestroyProducer(t), | ||
| Steps: []resource.TestStep{ |
There was a problem hiding this comment.
Can add more steps here to test the updating of the field preferred_zone?
There was a problem hiding this comment.
Can you elaborate on this , what other steps are needed? Since it's string field testing it for one zone should be suffice.
There was a problem hiding this comment.
Can you please add more test steps to update it from one zone to another zone? Thanks.
There was a problem hiding this comment.
The use case is first clone the instance to one zone, and then during the update, clone this instance to another zone. Is it allowed to clone the instance to another zone during the update?
There was a problem hiding this comment.
Got you point, since preferred zone is not P0, dropping it from this PR, will follow up later on that. So it won't affect timely merging of other changes in this PR
Can you please try to fix these tests? Thanks. |
Tests analyticsTotal tests: Action takenFound 62 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_maintenanceVersion|TestAccSqlDatabaseInstance_basicSecondGen|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_basicMSSQL|TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample|TestAccSQLDatabase_sqlDatabaseBasicExample|TestAccDataSourceSqlDatabases_basic|TestAccDataSourceSqlDatabase_basic|TestAccDataSourceSqlDatabaseInstances_tierFilter|TestAccDataSourceSqlDatabaseInstances_regionFilter|TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter|TestAccDataSourceSqlDatabaseInstances_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccSqlUser_postgresAbandon|TestAccSqlUser_postgresIAM|TestAccSqlUser_postgres|TestAccSqlClientCert_postgres|TestAccSqlClientCert_mysql|TestAccSqlDatabase_update|TestAccSqlDatabase_basic|TestAccSqlDatabaseInstance_ReplicaPromoteSkippedWithNoMasterInstanceNameAndNoReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNameAndReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNamePresent|TestAccSqlDatabaseInstance_ReplicaPromoteSuccessful|TestAccSqlDatabaseInstance_activationPolicy|TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable|TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample|TestAccSqlDatabaseInstance_Timezone|TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled|TestAccSqlDatabaseInstance_Smt|TestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccSQLDatabaseInstance_DenyMaintenancePeriod|TestAccSqlDatabaseInstance_encryptionKey|TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion|TestAccSqlDatabaseInstance_insights|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_BackupRetention|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccComputeFirewallPolicyRule_multipleRules|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_maintenance|TestAccSqlDatabaseInstance_diskspecs|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled|TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample|TestAccCloudRunV2Job_cloudrunv2JobSqlExample|TestAccCloudRunService_cloudRunServiceSqlExample |
|
Tests failed during RECORDING mode: Please fix these to complete your PR |
Combined Enterprise and EnterprisePlus Edition tests. Corrected data_cache_config test.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 255 insertions(+), 49 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
|
|
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 254 insertions(+), 49 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
1 similar comment
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 254 insertions(+), 49 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
1 similar comment
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
|
|
|
|
|
Tests failed during RECORDING mode You can ignore these two failed tests. |
| "edition": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| ValidateFunc: validation.StringInSlice([]string{"EDITION_UNSPECIFIED", "ENTERPRISE", "ENTERPRISE_PLUS"}, false), |
There was a problem hiding this comment.
EDITION_UNSPECIFIED can be deleted here.
We normally don't include UNSPECIFIED values for enums/strings because they're don't have a useful meaning.
There was a problem hiding this comment.
Removed EDITION_UNSPECIFIED.
|
|
||
| A timestamp in RFC3339 UTC "Zulu" format, with nanosecond resolution and up to nine fractional digits. Examples: "2014-10-02T15:01:23Z" and "2014-10-02T15:01:23.045123456Z". | ||
|
|
||
| * `preferred_zone` - (Optional) (Point-in-time recovery for PostgreSQL only) Clone to an instance in the specified zone. If no zone is specified, clone to the same zone as the source instance. |
There was a problem hiding this comment.
Can you also add examples for these new fields to this section? Thanks.
There was a problem hiding this comment.
Added an example of Enterprise edition with data_cache_config.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 192 insertions(+), 49 deletions(-)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 206 insertions(+), 49 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
|
|
zli82016
left a comment
zli82016
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making the changes.
…eCloudPlatform#8277) * Added support for sproviding edition in sql_database_instance * Added settings.edition, settings.data_cache_config, clone.preferred_zone in sql_database_instance * Update resource_sql_database_instance.go.erb Re-formatted code * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance_test.go Combined Enterprise and EnterprisePlus Edition tests. Corrected data_cache_config test. * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance_test.go * Update sql_database_instance.html.markdown
…eCloudPlatform#8277) * Added support for sproviding edition in sql_database_instance * Added settings.edition, settings.data_cache_config, clone.preferred_zone in sql_database_instance * Update resource_sql_database_instance.go.erb Re-formatted code * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance_test.go Combined Enterprise and EnterprisePlus Edition tests. Corrected data_cache_config test. * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance_test.go * Update sql_database_instance.html.markdown
…eCloudPlatform#8277) * Added support for sproviding edition in sql_database_instance * Added settings.edition, settings.data_cache_config, clone.preferred_zone in sql_database_instance * Update resource_sql_database_instance.go.erb Re-formatted code * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance_test.go Combined Enterprise and EnterprisePlus Edition tests. Corrected data_cache_config test. * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance_test.go * Update sql_database_instance.html.markdown
…eCloudPlatform#8277) * Added support for sproviding edition in sql_database_instance * Added settings.edition, settings.data_cache_config, clone.preferred_zone in sql_database_instance * Update resource_sql_database_instance.go.erb Re-formatted code * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance_test.go Combined Enterprise and EnterprisePlus Edition tests. Corrected data_cache_config test. * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance.go.erb * Update resource_sql_database_instance_test.go * Update sql_database_instance.html.markdown
4 participants
Added Edition field in settings block of sql_database_instance.
b/276260732
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)