Skip to content

Add issuanceConfig property to managed certificates#8276

Merged
trodge merged 2 commits into
GoogleCloudPlatform:mainfrom
Hamzawy63:certificate-manager-add-issuance-config-support-to-managed-certificates
Jul 8, 2023
Merged

Add issuanceConfig property to managed certificates#8276
trodge merged 2 commits into
GoogleCloudPlatform:mainfrom
Hamzawy63:certificate-manager-add-issuance-config-support-to-managed-certificates

Conversation

@Hamzawy63

@Hamzawy63 Hamzawy63 commented Jul 6, 2023

Copy link
Copy Markdown
Contributor
  • Added new immutable property issuanceConfig to Certificate resource.
  • Added new example that creates managed certificate with issuanceConfig

Fixes hashicorp/terraform-provider-google#15062

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.
certificatemanager: added `issuance_config` field to `google_certificate_manager_certificate` resource

@modular-magician

Copy link
Copy Markdown
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@modular-magician
modular-magician requested a review from trodge July 6, 2023 15:49
@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @trodge, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 6, 2023
immutable: true
description: |
Authorizations that will be used for performing domain authorization
Authorizations that will be used for performing domain authorization. Either issuanceConfig or dnsAuthorizations should be specificed, but not both.

@Hamzawy63 Hamzawy63 Jul 6, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have used the property exactly_one_of to enforce that only one of the two properties should be declared. However, That's not explicitly written in the API . That's why I only wrote it as a comment in the description.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 6, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 225 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 225 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 303 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_certificate_manager_certificate (0 total tests)
Untested fields: managed.issuance_config

Please add acceptance tests which include these fields.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2844
Passed tests 2501
Skipped tests: 295
Affected tests: 48

Action taken

Found 48 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BasicHandWritten|TestAccComputeRegionInstanceTemplate_with18TbScratchDisk|TestAccComputeRegionInstanceTemplate_withScratchDisk|TestAccComputeRegionInstanceTemplate_minCpuPlatform|TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip|TestAccComputeRegionInstanceTemplate_guestAccelerator|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeRegionInstanceTemplate_metadata_startup_script|TestAccComputeRegionInstanceTemplate_primaryAliasIpRange|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeInstanceTemplate_NetworkAttachment|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccComputeFirewallPolicyRule_multipleRules|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccCloudbuildv2Connection_GitlabConnection|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceTemplate_withScratchDisk|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample|TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateDnsExample|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeInstanceFromTemplate_self_link_unique|TestAccComputeInstanceFromTemplate_basic

Get to know how VCR tests work

@modular-magician
modular-magician requested a review from trodge July 6, 2023 21:04
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 6, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 225 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 225 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 303 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_certificate_manager_certificate (0 total tests)
Untested fields: managed.issuance_config

Please add acceptance tests which include these fields.

@Hamzawy63

Hamzawy63 commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

Hi there, I'm the Modular magician. I've detected the following information about your changes:

....

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_certificate_manager_certificate (0 total tests) Untested fields: managed.issuance_config

Please add acceptance tests which include these fields.

Why did Modular magician mention that the filed managed.issuance_config isn't tested? I already added an exmaple that contains the field. Did I miss something? @trodge

@trodge

trodge commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

Hi there, I'm the Modular magician. I've detected the following information about your changes:
....

Missing test report

Your PR includes resource fields which are not covered by any test.
Resource: google_certificate_manager_certificate (0 total tests) Untested fields: managed.issuance_config
Please add acceptance tests which include these fields.

Why did Modular magician mention that the filed managed.issuance_config isn't tested? I already added an exmaple that contains the field. Did I miss something? @trodge

There is currently an issue with the missing test detector which #8280 will fix.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2832
Passed tests 2533
Skipped tests: 295
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample|TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateDnsExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests passed during RECORDING mode:
TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample[Debug log]
TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateDnsExample[Debug log]

Tests failed during RECORDING mode:
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@trodge
trodge merged commit ef3df4c into GoogleCloudPlatform:main Jul 8, 2023
baskaran-md pushed a commit to baskaran-md/magic-modules that referenced this pull request Jul 10, 2023
…orm#8276)

* Add issuanceConfig property to managed certificates

* Remove trailing spaces in Certificate.yaml

---------

Co-authored-by: Hamza Hassan <hamzahassan@google.com>
Khaledmohamedrefaat pushed a commit to Khaledmohamedrefaat/magic-modules that referenced this pull request Jul 13, 2023
…orm#8276)

* Add issuanceConfig property to managed certificates

* Remove trailing spaces in Certificate.yaml

---------

Co-authored-by: Hamza Hassan <hamzahassan@google.com>
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…orm#8276)

* Add issuanceConfig property to managed certificates

* Remove trailing spaces in Certificate.yaml

---------

Co-authored-by: Hamza Hassan <hamzahassan@google.com>
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
…orm#8276)

* Add issuanceConfig property to managed certificates

* Remove trailing spaces in Certificate.yaml

---------

Co-authored-by: Hamza Hassan <hamzahassan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to create managed certificates with issuance-config in certificatemanager

3 participants