TC config - splitting test configuration out by service by megan07 · Pull Request #8254 · GoogleCloudPlatform/magic-modules

megan07 · 2023-06-30T21:26:14Z

Creates the TC configuration that will allow us to run tests per package/service. We'll want to combine this in some way with a PR that splits out all the tests, or stub out some tests in each package/service directory.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2023-06-30T21:43:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 665 insertions(+))
Terraform Beta: Diff ( 15 files changed, 675 insertions(+))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

SarahFrench

Approving as this PR generates the same code as what currently exists in a feature branch in the TPGB repo (+ similar for my TPG branch).

I've left a few comments, but they're either some small suggestions about comments to add to files, or they are a review comment made for the benefit of people reading this PR in future and not relevant to us now :)

SarahFrench · 2023-07-05T19:52:11Z

+//
+// Until that changes, we'll continue to use `teamcity-go-test` to run
+// each test individually
+const val useTeamCityGoTest = false


Just highlighting this part of the code for discovery if people look at this PR in future. useTeamCityGoTest controls some if/else logs in parts of this config code (e.g. L19 and L61 in this file, and .teamcity/tests/generated/configuration.erb) but the code will alway use the same branches due to this value being set to false here.

👆 For benefit of people reading this PR in the future

zli82016

LGTM

…ackage.kt Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

zli82016

LGTM based on the comments.

SarahFrench · 2023-07-07T16:45:41Z

I just spotted that this PR is marked as having a contributor who hasn't signed the CLA - this is due to Megan leaving HashiCorp between the time this PR was opened and when the PR will be merged 😢 .
My plan is to ignore that warning, because the CLA issue is referencing Megan's old hashicorp work email address, so I don't think it's something that can be addressed? And the CLA was agreed to at the time of the PR being made.

Though @megan07 you're welcome to sign the CLA as an individual in case you're going to make future contributions 😉

SarahFrench · 2023-07-07T18:06:24Z

~~Plan is to merge this on Monday, without the service-split PR.~~

Edit: Merging today (Tues 11 July) but will need to write up considerations about quotas and parallelism before moving tests to the service packages

…latform#8254) * add .teamcity folder * update .teamcity folder * fix mistakes * add sweeper steps * Update mmv1/third_party/terraform/.teamcity/components/build_config_package.kt Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Update mmv1/third_party/terraform/.teamcity/components/build_google.kt Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Update mmv1/third_party/terraform/.teamcity/generated/settings.kts.erb Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Update mmv1/third_party/terraform/.teamcity/tests/helpers.kt Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

megan07 added 4 commits June 27, 2023 10:16

add .teamcity folder

997a5a9

update .teamcity folder

2f82a57

fix mistakes

f4403f5

add sweeper steps

5910cf2

SarahFrench self-requested a review July 5, 2023 18:18

megan07 requested a review from zli82016 July 5, 2023 19:11

SarahFrench approved these changes Jul 5, 2023

View reviewed changes

zli82016 reviewed Jul 6, 2023

View reviewed changes

Comment thread mmv1/third_party/terraform/.teamcity/components/packages.kt

zli82016 approved these changes Jul 6, 2023

View reviewed changes

megan07 and others added 4 commits July 6, 2023 16:47

Update mmv1/third_party/terraform/.teamcity/components/build_config_p…

9eb03e5

…ackage.kt Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

Update mmv1/third_party/terraform/.teamcity/components/build_google.kt

7543080

Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

Update mmv1/third_party/terraform/.teamcity/generated/settings.kts.erb

0c787ad

Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

Update mmv1/third_party/terraform/.teamcity/tests/helpers.kt

3f41728

Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

modular-magician requested review from SarahFrench and zli82016 July 6, 2023 21:47

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 6, 2023

zli82016 approved these changes Jul 7, 2023

View reviewed changes

SarahFrench approved these changes Jul 7, 2023

View reviewed changes

SarahFrench merged commit 8c255bc into GoogleCloudPlatform:main Jul 11, 2023

This was referenced Jul 11, 2023

TC config - splitting test configuration out by service hashicorp/terraform-provider-google-beta#5870

Merged

TC config - splitting test configuration out by service hashicorp/terraform-provider-google#15128

Merged

SarahFrench mentioned this pull request Jul 13, 2023

Add tool to generate services.kt file that contains mmv1 and tpgtools/DCL services #8344

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

TC config - splitting test configuration out by service#8254

TC config - splitting test configuration out by service#8254
SarahFrench merged 8 commits into
GoogleCloudPlatform:mainfrom
hashicorp:megan_tc_services

megan07 commented Jun 30, 2023

Uh oh!

modular-magician commented Jun 30, 2023

Uh oh!

SarahFrench left a comment

Uh oh!

Uh oh!

SarahFrench Jul 5, 2023

Uh oh!

SarahFrench Jul 5, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zli82016 left a comment

Uh oh!

zli82016 left a comment

Uh oh!

SarahFrench commented Jul 7, 2023

Uh oh!

SarahFrench commented Jul 7, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

megan07 commented Jun 30, 2023

Uh oh!

modular-magician commented Jun 30, 2023

Diff report

Uh oh!

SarahFrench left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SarahFrench Jul 5, 2023

Choose a reason for hiding this comment

Uh oh!

SarahFrench Jul 5, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zli82016 left a comment

Choose a reason for hiding this comment

Uh oh!

zli82016 left a comment

Choose a reason for hiding this comment

Uh oh!

SarahFrench commented Jul 7, 2023

Uh oh!

SarahFrench commented Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SarahFrench commented Jul 7, 2023 •

edited

Loading