Skip to content

Add resource_ancestor#8245

Merged
slevenick merged 3 commits into
GoogleCloudPlatform:mainfrom
jenshonkan84:billing_budget_resource_ancestor
Aug 3, 2023
Merged

Add resource_ancestor#8245
slevenick merged 3 commits into
GoogleCloudPlatform:mainfrom
jenshonkan84:billing_budget_resource_ancestor

Conversation

@jenshonkan84

@jenshonkan84 jenshonkan84 commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Adds support for Resource Ancestors for billing budgets.

Fixes hashicorp/terraform-provider-google#14913

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

billing_budget: added `resource_ancestors` field to `google_billing_budget` resource

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 30, 2023
@jenshonkan84

jenshonkan84 commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

Have I missed something? Or can someone approve this?
@slevenick

@slevenick

Copy link
Copy Markdown
Contributor

Looks like I missed it, sorry. Running build now

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 31, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 58 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 58 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 3 files changed, 15 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2909
Passed tests 2603
Skipped tests: 302
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccBillingBudget_billingBudgetFilterExample|TestAccBillingBudget_billingFilterSubaccounts|TestAccBillingBudget_billingBudgetUpdate

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBillingBudget_billingFilterSubaccounts[Debug log]
TestAccBillingBudget_billingBudgetUpdate[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccBillingBudget_billingBudgetFilterExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@slevenick slevenick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failing due to datasource setup, needs a fix

Comment thread mmv1/templates/terraform/examples/billing_budget_filter.tf.erb Outdated
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 2, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 53 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 53 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 3 files changed, 15 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2917
Passed tests 2614
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBillingBudget_billingBudgetFilterExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBillingBudget_billingBudgetFilterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}
View the build log or the debug log for each test

@r-vennam

r-vennam commented Aug 3, 2023

Copy link
Copy Markdown

@slevenick can you please check this PR as we are in need of this feature too via terraform

@slevenick slevenick merged commit b4ceceb into GoogleCloudPlatform:main Aug 3, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 3, 2023
* Add resource_ancestor

* Fix Example test
jeperetz pushed a commit to jeperetz/magic-modules that referenced this pull request Aug 10, 2023
* Add resource_ancestor

* Fix Example test
@nphilbrook

Copy link
Copy Markdown
Contributor

Thank you @jenshonkan84 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_billing_budget: Support resourceAncestors

5 participants