Add resource_ancestor#8245
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
|
Have I missed something? Or can someone approve this? |
|
Looks like I missed it, sorry. Running build now |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 58 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccBillingBudget_billingBudgetFilterExample|TestAccBillingBudget_billingFilterSubaccounts|TestAccBillingBudget_billingBudgetUpdate |
|
Rerun these tests in REPLAYING mode to catch issues
|
slevenick
left a comment
There was a problem hiding this comment.
Test failing due to datasource setup, needs a fix
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 53 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBillingBudget_billingBudgetFilterExample |
|
Rerun these tests in REPLAYING mode to catch issues$\textcolor{green}{\textsf{All tests passed!}} |
|
@slevenick can you please check this PR as we are in need of this feature too via terraform |
* Add resource_ancestor * Fix Example test
* Add resource_ancestor * Fix Example test
|
Thank you @jenshonkan84 ! |
Adds support for Resource Ancestors for billing budgets.
Fixes hashicorp/terraform-provider-google#14913
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)