Skip to content

Cleaned up how magic modules works document#8188

Merged
melinath merged 3 commits into
mainfrom
docs-how-magic-modules-works-improvement
Jun 23, 2023
Merged

Cleaned up how magic modules works document#8188
melinath merged 3 commits into
mainfrom
docs-how-magic-modules-works-improvement

Conversation

@melinath

Copy link
Copy Markdown
Member

Set up a parallel construction that goes from broad organizational concepts to more detailed ones and links correctly to common code locations.

localhost_1313_magic-modules_get-started_how-magic-modules-works_ (2)

Release Note Template for Downstream PRs (will be copied)


Set up a parallel construction that goes from broad organizational concepts to more detailed ones and links correctly to common code locations.
@melinath melinath requested review from a team and zli82016 and removed request for a team June 22, 2023 19:14
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2810
Passed tests 2507
Skipped tests: 301
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@melinath melinath changed the title Cleaned up how magic modules works Cleaned up how magic modules works document Jun 22, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests passed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the doc. Left comments.

Comment thread docs/content/get-started/how-magic-modules-works.md Outdated
Comment thread docs/content/get-started/how-magic-modules-works.md Outdated
@melinath melinath requested a review from zli82016 June 23, 2023 17:08

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@melinath melinath merged commit 0f8264e into main Jun 23, 2023
@melinath melinath deleted the docs-how-magic-modules-works-improvement branch June 23, 2023 17:28
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2810
Passed tests 2507
Skipped tests: 301
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeNetworkEndpoints_networkEndpointsBasic

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests passed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Jun 27, 2023
* Cleaned up how magic modules works

Set up a parallel construction that goes from broad organizational concepts to more detailed ones and links correctly to common code locations.

* Corrected datasource implementation path

* Clarified grammar
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
* Cleaned up how magic modules works

Set up a parallel construction that goes from broad organizational concepts to more detailed ones and links correctly to common code locations.

* Corrected datasource implementation path

* Clarified grammar
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
* Cleaned up how magic modules works

Set up a parallel construction that goes from broad organizational concepts to more detailed ones and links correctly to common code locations.

* Corrected datasource implementation path

* Clarified grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants