fix %{random_suffix} in docs -8#8041
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @roaks3, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 8 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccIAM2DenyPolicy_iamDenyPolicyBasicExample|TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccFirebaseProject_destroyAndReapply|TestAccFirebaseProjectLocation_firebaseProjectLocationBasicExample|TestAccFirebaseProject_firebaseProjectBasicExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig |
|
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 8 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccIAM2DenyPolicy_iamDenyPolicyBasicExample|TestAccFirebaseProject_destroyAndReapply|TestAccComputeFirewallPolicyRule_multipleRules |
|
Tests passed during RECORDING mode: Rerun these tests in REPLAYING mode to catch issuesAll tests passed after rerunning REPLAYING mode. Tests failed during RECORDING mode: Please fix these to complete your PR |
|
@edwardmedia just checking since this was re-opened. Is this ready for review now? |
|
yes. ready for review. @roaks3 |
roaks3
left a comment
There was a problem hiding this comment.
One typo, but otherwise LGTM
6825801 to
1c29d61
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 8 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccIAM2DenyPolicy_iamDenyPolicyBasicExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeTargetHttpProxy_targetHttpProxyHttpKeepAliveTimeoutExample|TestAccComputeFirewallPolicyRule_multipleRules |
|
Rerun these tests in REPLAYING mode to catch issues
|
* fix %{random_suffix} in docs -8
* updated one test
* fix a typo
---------
Co-authored-by: Edward Sun <sunedward@google.com>
* fix %{random_suffix} in docs -8
* updated one test
* fix a typo
---------
Co-authored-by: Edward Sun <sunedward@google.com>
* fix %{random_suffix} in docs -8
* updated one test
* fix a typo
---------
Co-authored-by: Edward Sun <sunedward@google.com>
* fix %{random_suffix} in docs -8
* updated one test
* fix a typo
---------
Co-authored-by: Edward Sun <sunedward@google.com>
* fix %{random_suffix} in docs -8
* updated one test
* fix a typo
---------
Co-authored-by: Edward Sun <sunedward@google.com>
Fixes hashicorp/terraform-provider-google#14236
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)