Add new resource Apigee Keystore Alias for Self Signed Cert#7472
Closed
anuhyapolisetti wants to merge 27 commits into
Closed
Add new resource Apigee Keystore Alias for Self Signed Cert#7472anuhyapolisetti wants to merge 27 commits into
anuhyapolisetti wants to merge 27 commits into
Conversation
anuhyapolisetti
requested review from
rileykarson
and removed request for
a team
anuhyapolisetti
changed the title
* main: (41 commits) update the test cases to resolve resourcename not found error Adds `grpc` field to `liveness_probe` and `startup_probe` to `google_cloud_run_v2_service` resource (GoogleCloudPlatform#6987) Upgrade DCL to v1.34 (GoogleCloudPlatform#7276) Add max_distance field to group placement policy (GoogleCloudPlatform#7354) Add stateful_ips to region_per_instance_config and per_instance_config (GoogleCloudPlatform#7316) Added support for workload-vulnerability-scanning and workload-config-audit (GoogleCloudPlatform#7310) datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#6989) Added best practices documentation for ForceNew fields (GoogleCloudPlatform#7127) Split resources in "B" products (GoogleCloudPlatform#7350) force recreate on master_config.num_instances (GoogleCloudPlatform#7349) Fix DataFusion instance versions used in tests (GoogleCloudPlatform#7343) remove duplicate word in Cluster.yaml (GoogleCloudPlatform#7347) Move more billing tests that require permissions beyond Billing User to master billing account (GoogleCloudPlatform#7344) Remove artifact repository beta URL, fixup handwritten tests (GoogleCloudPlatform#7345) Cloud Workstations - Workstation Config (GoogleCloudPlatform#7017) Add missing `type` argument to data source docs (GoogleCloudPlatform#7341) Fix caps in spanner resource schema accesses (GoogleCloudPlatform#7346) Downgrade Go to 1.18, modify comments (GoogleCloudPlatform#7339) feat: Add support for deletion_policy on shared vpc service project (GoogleCloudPlatform#7283) fixed virtual field update issues (GoogleCloudPlatform#7318) ...
rileykarson
reviewed
Mar 16, 2023
| # limitations under the License. | ||
|
|
||
| --- !ruby/object:Api::Resource | ||
| name: 'EnvKeystoreAliasesSelfSigned' |
Member
There was a problem hiding this comment.
I see in https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.environments.keystores.aliases/create that it refers to CertificateGenerationSpec but I can't find any details on that type. Do you have a link to it?
| input: true | ||
| url_param_only: true | ||
| - !ruby/object:Api::Type::String | ||
| name: 'name' |
Member
There was a problem hiding this comment.
Right now this value is optional, but not possible to send as a query parameter in create: https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.environments.keystores/create#query-parameters. We need to add the parameter to the create_url to change that.
Would it make sense to just make this a required field, through Terraform? Default names can cause a lot of complications.
| name: 'name' | ||
| description: | | ||
| The name of the newly created keystore. | ||
| input: true |
Member
There was a problem hiding this comment.
note: The regex used by the API accepts spaces, so we should test a name that includes them.
Contributor
Author
|
Most of them are addressed in PR -#7488 , Closing this as it is a duplicate too |
5 tasks
This was referenced Apr 7, 2023
Update apigee keystore resource names to be consistent
hashicorp/terraform-provider-google-beta#5454
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for the Apigee keystore alias for selfsigned format, implements the provider for the APIs - https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.environments.keystores.aliases/create
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)