Skip to content

Fix DataFusion instance versions used in tests #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roaks3 merged 1 commit into from
Feb 24, 2023
Merged

Fix DataFusion instance versions used in tests #7343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mmv1/templates/terraform/examples/data_fusion_instance_event.tf.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ resource "google_data_fusion_instance" "<%= ctx[:primary_resource_id] %>" {
name = "<%= ctx[:vars]["instance_name"] %>"
region = "us-central1"
type = "BASIC"
version = "6.7.0"

event_publish_config {
enabled = true
Expand Down
1 change: 0 additions & 1 deletion mmv1/templates/terraform/examples/data_fusion_instance_full.tf.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ resource "google_data_fusion_instance" "<%= ctx[:primary_resource_id] %>" {
enable_stackdriver_logging = true
enable_stackdriver_monitoring = true
private_instance = true
version = "6.6.0"
dataproc_service_account = data.google_app_engine_default_service_account.default.email

labels = {
Expand Down
5 changes: 3 additions & 2 deletions mmv1/third_party/terraform/tests/resource_data_fusion_instance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ resource "google_data_fusion_instance" "foobar" {
name = "%s"
region = "us-central1"
type = "BASIC"
version = "6.1.1"
# See supported versions here https://cloud.google.com/data-fusion/docs/support/version-support-policy
version = "6.7.0"
# Mark for testing to avoid service networking connection usage that is not cleaned up
options = {
prober_test_run = "true"
Expand All @@ -64,7 +65,7 @@ resource "google_data_fusion_instance" "foobar" {
label1 = "value1"
label2 = "value2"
}
version = "6.2.0"
version = "6.8.0"
# Mark for testing to avoid service networking connection usage that is not cleaned up
options = {
prober_test_run = "true"
Expand Down