Adds GRPC probe support to google_cloud_run_v2_service resource#7172
Adds GRPC probe support to google_cloud_run_v2_service resource#7172yanweiguo wants to merge 1 commit into
google_cloud_run_v2_service resource#7172Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 244 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccCloudRunV2Service_cloudrunv2ServiceProbesExample|TestAccCloudRunV2Service_cloudrunv2ServiceProbesUpdate |
|
Closing this in favor of #6987. |
A follow-up of #6850. Similar to #6781.
NOTE: I added a test in main...yanweiguo:magic-modules:grpc_v2_with_test and made sure it passed locally. However there's no public GRPC app so I deleted the test after local testing.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)