Bigquery table - object table arg by DrFaust92 · Pull Request #7128 · GoogleCloudPlatform/magic-modules

DrFaust92 · 2023-01-14T19:02:25Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: table - add `external_data_configuration.metadata_cache_mode` and `external_data_configuration.object_metadata`

bigquery: table - make `external_data_configuration.source_fomat` optional

modular-magician · 2023-01-14T19:03:33Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2023-01-14T19:17:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 108 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 108 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-14T20:08:19Z

Tests analytics

Total tests: 2420
Passed tests 2167
Skipped tests: 252
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigQueryExternalDataTable_objectTable

modular-magician · 2023-01-14T20:08:57Z

Tests passed during RECORDING mode:
TestAccBigQueryExternalDataTable_objectTable[Debug log]

All tests passed
View the build log or the debug log for each test

slevenick · 2023-02-27T16:12:16Z

/gcbrun

modular-magician · 2023-02-27T16:28:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 166 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 166 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-27T17:11:38Z

Tests analytics

Total tests: 2474
Passed tests 2216
Skipped tests: 255
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccBigQueryExternalDataTable_objectTable|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

modular-magician · 2023-02-27T18:02:34Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccBigQueryExternalDataTable_objectTable[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

DrFaust92 · 2023-04-04T14:19:37Z

@slevenick any update?

slevenick · 2023-04-04T14:36:58Z

/gcbrun

DrFaust92 · 2023-04-06T17:35:29Z

slevenick rebased and fixed some change that i didnt have in my branch (and tested)

slevenick · 2023-04-06T17:38:01Z

/gcbrun

DrFaust92 · 2023-05-08T05:06:25Z

slevenick anything else needed here?

slevenick · 2023-05-08T16:18:52Z

/gcbrun

modular-magician · 2023-05-08T16:42:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 168 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 168 insertions(+), 2 deletions(-))

modular-magician · 2023-05-08T16:44:39Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

slevenick

Sorry, I thought I triggered the build but it never got back in my queue.

Looks like there's a function that's been renamed, can you fix that and then we should be good to go after tests run

slevenick · 2023-05-08T16:52:21Z

+	connectionID := fmt.Sprintf("tf_test_%s", RandString(t, 10))
+
+	VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { testAccPreCheck(t) },


I think this is TestAccPreCheck now

DrFaust92 · 2023-06-05T16:46:58Z

slevenick sorry about this, pong

modular-magician · 2023-06-05T19:05:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 168 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 168 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-06-05T20:07:27Z

Tests analytics

Total tests: 2772
Passed tests 2482
Skipped tests: 285
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-06-05T20:21:49Z

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

DrFaust92 · 2023-07-07T14:45:15Z

slevenick can you take another look? would love to push this

modular-magician · 2023-07-07T18:03:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 168 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 168 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-07-07T19:20:29Z

Tests analytics

Total tests: 2831
Passed tests 2534
Skipped tests: 295
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-07-07T19:23:01Z

Tests failed during RECORDING mode:
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

DrFaust92 · 2023-07-07T21:07:03Z

Thank you @slevenick !!!!!!

* add args * docs and conflict * object table * add test for metadata_cache_mode * add field update * rebase * rebase

modular-magician requested a review from slevenick January 14, 2023 19:03

slevenick reviewed Feb 2, 2023

View reviewed changes

Comment thread mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown

DrFaust92 force-pushed the bq-table-object-table branch from d12b79f to f581b3b Compare February 25, 2023 18:45

DrFaust92 requested a review from a team as a code owner February 25, 2023 18:45

melinath assigned slevenick Feb 27, 2023

modular-magician requested a review from slevenick February 27, 2023 16:13

slevenick reviewed Feb 28, 2023

View reviewed changes

Comment thread mmv1/third_party/terraform/resources/resource_bigquery_table.go Outdated

Comment thread mmv1/third_party/terraform/tests/resource_bigquery_table_test.go

DrFaust92 force-pushed the bq-table-object-table branch from f581b3b to 4d48391 Compare March 17, 2023 15:06

DrFaust92 requested a review from slevenick March 27, 2023 06:11

DrFaust92 force-pushed the bq-table-object-table branch from 4d48391 to cdd8fa2 Compare April 6, 2023 17:30

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 6, 2023

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 8, 2023

slevenick requested changes May 8, 2023

View reviewed changes

DrFaust92 force-pushed the bq-table-object-table branch from cdd8fa2 to 3e9cd3a Compare May 9, 2023 12:38

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 5, 2023

DrFaust92 added 7 commits July 5, 2023 17:59

add args

56bf17b

docs and conflict

024359c

object table

821777d

add test for metadata_cache_mode

5223c34

add field update

a4a4cdb

rebase

323c16c

rebase

7130b1a

DrFaust92 force-pushed the bq-table-object-table branch from 55a0466 to 7130b1a Compare July 5, 2023 14:59

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 5, 2023

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 7, 2023

slevenick approved these changes Jul 7, 2023

View reviewed changes

slevenick merged commit 6349dc3 into GoogleCloudPlatform:main Jul 7, 2023

DrFaust92 deleted the bq-table-object-table branch July 7, 2023 21:07

DrFaust92 mentioned this pull request Jul 10, 2023

Support BigQuery GCS Object Metadata external table hashicorp/terraform-provider-google#14694

Closed

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

Bigquery table - object table arg (GoogleCloudPlatform#7128)

28af858

* add args * docs and conflict * object table * add test for metadata_cache_mode * add field update * rebase * rebase

wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023

Bigquery table - object table arg (GoogleCloudPlatform#7128)

fbd72a8

* add args * docs and conflict * object table * add test for metadata_cache_mode * add field update * rebase * rebase

Uh oh!

Conversation

DrFaust92 commented Jan 14, 2023

Uh oh!

modular-magician commented Jan 14, 2023

Uh oh!

modular-magician commented Jan 14, 2023

Diff report

Uh oh!

modular-magician commented Jan 14, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 14, 2023

Uh oh!

Uh oh!

slevenick commented Feb 27, 2023

Uh oh!

modular-magician commented Feb 27, 2023

Diff report

Uh oh!

modular-magician commented Feb 27, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 27, 2023

Uh oh!

Uh oh!

Uh oh!

DrFaust92 commented Apr 4, 2023

Uh oh!

slevenick commented Apr 4, 2023

Uh oh!

DrFaust92 commented Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slevenick commented Apr 6, 2023

Uh oh!

DrFaust92 commented May 8, 2023

Uh oh!

slevenick commented May 8, 2023

Uh oh!

modular-magician commented May 8, 2023

Diff report

Uh oh!

modular-magician commented May 8, 2023

Tests analytics

Uh oh!

slevenick left a comment

Choose a reason for hiding this comment

Uh oh!

slevenick May 8, 2023

Choose a reason for hiding this comment

Uh oh!

DrFaust92 commented Jun 5, 2023

Uh oh!

modular-magician commented Jun 5, 2023

Diff report

Uh oh!

modular-magician commented Jun 5, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jun 5, 2023

Uh oh!

DrFaust92 commented Jul 7, 2023

Uh oh!

modular-magician commented Jul 7, 2023

Diff report

Uh oh!

modular-magician commented Jul 7, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jul 7, 2023

Uh oh!

DrFaust92 commented Jul 7, 2023

Uh oh!

Reviewers

Assignees

DrFaust92 commented Apr 6, 2023 •

edited

Loading