fix: make google_compute_network mtu field updatable#4349
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=164767" |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceStorageBucketObjectContent_Basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccContainerCluster_withIPv4Error|TestAccContainerNodePool_withKubeletConfig|TestAccDataprocJob_Spark You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=164778" |
There was a problem hiding this comment.
It looks like the Network resource is marked as input: true as a whole, which means that it is irrelevant what the individual properties say. I think you will need to remove that line as well. It looks like the resource can be patched, so that line (marking the entire resource as input-only) is probably a mistake.
|
@bharathkkb just wanted to check in whether you're still working on this PR? |
|
I'm closing this issue since it's been inactive for a long time now. Please open a new PR if you're still interested in working on this issue. |
fixes hashicorp/terraform-provider-google#8091
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)