Skip to content

feat(compute): Add instance group manager bulk per instance config re…#18070

Merged
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
chayankumar999:bulk-per-instance-config
Jun 25, 2026
Merged

feat(compute): Add instance group manager bulk per instance config re…#18070
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
chayankumar999:bulk-per-instance-config

Conversation

@chayankumar999

@chayankumar999 chayankumar999 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR introduces a new virtual resource for instance group managers: BulkPerInstanceConfig.

In this version it accepts only instance names which makes it possible to call instanceGroupManagers.CreateInstances with more than 1 instance in a single call. So far it was limited to a single PerInstanceConfig.

BulkPerInstanceConfig is immutable and on each modification it will call instanceGroupManagers.DeleteInstances on Destroy and instanceGroupManagers.CreateInstances on Create. Thanks to that Update is not implemented.

instance group manager should be configured to ignore target_size changes, as BulkPerInstanceConfig modifies this value.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_compute_bulk_per_instance_config`

@chayankumar999 chayankumar999 marked this pull request as draft June 24, 2026 20:13
@github-actions github-actions Bot requested a review from melinath June 24, 2026 20:13
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e9d33bf:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 988 insertions(+)
google-beta provider View Diff 4 files changed, 988 insertions(+)
terraform-google-conversion View Diff 1 file changed, 150 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 151 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1494 1400 93 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

View the replaying VCR build log


Step 2: Recording Mode

Caution

Panic occurred during VCR tests

🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@chayankumar999, @melinath VCR tests complete for e9d33bf!

@chayankumar999 chayankumar999 force-pushed the bulk-per-instance-config branch 2 times, most recently from f27aa64 to 69f47ab Compare June 24, 2026 20:58
@modular-magician

modular-magician commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f27aa64:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 981 insertions(+)
google-beta provider View Diff 4 files changed, 981 insertions(+)
terraform-google-conversion View Diff 1 file changed, 150 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 151 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1494 1400 93 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chayankumar999, @melinath VCR tests complete for f27aa64!

@chayankumar999 chayankumar999 force-pushed the bulk-per-instance-config branch from 69f47ab to d6e391e Compare June 24, 2026 21:00
@modular-magician

modular-magician commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 69f47ab:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 981 insertions(+)
google-beta provider View Diff 4 files changed, 981 insertions(+)
terraform-google-conversion View Diff 1 file changed, 150 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 151 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1495 1401 93 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chayankumar999, @melinath VCR tests complete for 69f47ab!

@modular-magician

modular-magician commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d6e391e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 981 insertions(+)
google-beta provider View Diff 4 files changed, 981 insertions(+)
terraform-google-conversion View Diff 1 file changed, 150 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 151 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1495 1401 93 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chayankumar999, @melinath VCR tests complete for d6e391e!

@chayankumar999 chayankumar999 force-pushed the bulk-per-instance-config branch from d6e391e to 5b42368 Compare June 24, 2026 21:54
@modular-magician

modular-magician commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5b42368:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 967 insertions(+)
google-beta provider View Diff 4 files changed, 967 insertions(+)
terraform-google-conversion View Diff 1 file changed, 150 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 150 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1503 1407 94 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample
  • TestAccComputeInstance_performanceMonitoringUnit

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeInstance_performanceMonitoringUnit
❌ Error · Log - TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chayankumar999, @melinath VCR tests complete for 5b42368!

@chayankumar999 chayankumar999 force-pushed the bulk-per-instance-config branch from 5b42368 to 63659c9 Compare June 25, 2026 10:05
api_variant_patterns:
- 'projects/{project}/zones/{zone}/instanceGroupManagers/{instanceGroupManager}'
description: |
A config defined for multiple managed instances that belong to an instance group manager related to 'BULK MIG'.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"related to BULK MIG" doesn't sound perfect to me.

"with target_size_policy.mode=BULK"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 63659c9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1011 insertions(+)
google-beta provider View Diff 4 files changed, 1011 insertions(+)
terraform-google-conversion View Diff 1 file changed, 150 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 150 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1503 1408 94 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@chayankumar999, @melinath VCR tests complete for 63659c9!

@chayankumar999 chayankumar999 force-pushed the bulk-per-instance-config branch from 63659c9 to 7c18f10 Compare June 25, 2026 10:18
@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7c18f10:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1011 insertions(+)
google-beta provider View Diff 4 files changed, 1011 insertions(+)
terraform-google-conversion View Diff 1 file changed, 150 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 150 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1503 1407 94 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample
✅ Log TestAccComputeRouterPeer_UpdateMd5AuthenticationKey

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@chayankumar999, @melinath VCR tests complete for 7c18f10!

@chayankumar999 chayankumar999 marked this pull request as ready for review June 25, 2026 10:30
@chayankumar999 chayankumar999 force-pushed the bulk-per-instance-config branch from 7c18f10 to a074e20 Compare June 25, 2026 10:32
@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a074e20:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1011 insertions(+)
google-beta provider View Diff 4 files changed, 1011 insertions(+)
terraform-google-conversion View Diff 1 file changed, 150 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 150 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1503 1408 94 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@chayankumar999, @melinath VCR tests complete for a074e20!

@askubis

askubis commented Jun 25, 2026

Copy link
Copy Markdown
Member

We did manual tests today, including waiting for the deletion. all looks good.

@chayankumar999 chayankumar999 force-pushed the bulk-per-instance-config branch from a074e20 to 26203d0 Compare June 25, 2026 12:14
@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 26203d0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1011 insertions(+)
google-beta provider View Diff 4 files changed, 1011 insertions(+)
terraform-google-conversion View Diff 1 file changed, 150 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 150 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1503 1407 94 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey
✅ Log TestAccComputeRouterPeer_UpdateMd5AuthenticationKey

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@chayankumar999, @melinath VCR tests complete for 26203d0!

Comment thread mmv1/products/compute/BulkPerInstanceConfig.yaml
Comment thread mmv1/products/compute/BulkPerInstanceConfig.yaml Outdated
Comment thread mmv1/templates/terraform/custom_delete/compute_bulk_per_instance_config.go.tmpl Outdated
@chayankumar999 chayankumar999 force-pushed the bulk-per-instance-config branch from 26203d0 to b0413e0 Compare June 25, 2026 17:01
@github-actions github-actions Bot requested a review from slevenick June 25, 2026 17:02
@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b0413e0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1017 insertions(+)
google-beta provider View Diff 4 files changed, 1017 insertions(+)
terraform-google-conversion View Diff 1 file changed, 151 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 150 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1503 1408 94 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeBulkPerInstanceConfig_computeBulkPerInstanceConfigExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@chayankumar999, @melinath, @slevenick VCR tests complete for b0413e0!

@chayankumar999 chayankumar999 force-pushed the bulk-per-instance-config branch from b0413e0 to ec12dc0 Compare June 25, 2026 17:38
@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ec12dc0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1025 insertions(+)
google-beta provider View Diff 4 files changed, 1025 insertions(+)
terraform-google-conversion View Diff 1 file changed, 151 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 150 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1503 1409 94 0
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@chayankumar999, @melinath VCR tests complete for ec12dc0!

@chayankumar999

Copy link
Copy Markdown
Contributor Author

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ec12dc0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1025 insertions(+)
google-beta provider View Diff 4 files changed, 1025 insertions(+)
terraform-google-conversion View Diff 1 file changed, 151 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 150 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_bulk_per_instance_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. An override-missing-service-label label can be added to allow merging.

I don't know why it's still complaining about this, though it should have been added already. Also opening the link https://console.cloud.google.com/cloud-build/builds;region=global/11930931-69fc-4299-81e7-9a621a4b2399;step=17?project=graphite-docker-images from the failed check doesn't show any errors.

@slevenick slevenick added this pull request to the merge queue Jun 25, 2026
@slevenick slevenick removed this pull request from the merge queue due to a manual request Jun 25, 2026
@slevenick

Copy link
Copy Markdown
Contributor

Waiting on test rerun to finish, but it should pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants