feat(compute): Add instance group manager bulk per instance config re…#18070
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e9d33bf: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log @chayankumar999, @melinath VCR tests complete for e9d33bf! |
f27aa64 to
69f47ab
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f27aa64: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @chayankumar999, @melinath VCR tests complete for f27aa64! |
69f47ab to
d6e391e
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 69f47ab: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @chayankumar999, @melinath VCR tests complete for 69f47ab! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d6e391e: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @chayankumar999, @melinath VCR tests complete for d6e391e! |
d6e391e to
5b42368
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5b42368: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @chayankumar999, @melinath VCR tests complete for 5b42368! |
5b42368 to
63659c9
Compare
| api_variant_patterns: | ||
| - 'projects/{project}/zones/{zone}/instanceGroupManagers/{instanceGroupManager}' | ||
| description: | | ||
| A config defined for multiple managed instances that belong to an instance group manager related to 'BULK MIG'. |
There was a problem hiding this comment.
"related to BULK MIG" doesn't sound perfect to me.
"with target_size_policy.mode=BULK"?
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 63659c9: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @chayankumar999, @melinath VCR tests complete for 63659c9! |
63659c9 to
7c18f10
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7c18f10: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @chayankumar999, @melinath VCR tests complete for 7c18f10! |
7c18f10 to
a074e20
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a074e20: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @chayankumar999, @melinath VCR tests complete for a074e20! |
|
We did manual tests today, including waiting for the deletion. all looks good. |
a074e20 to
26203d0
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 26203d0: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @chayankumar999, @melinath VCR tests complete for 26203d0! |
26203d0 to
b0413e0
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b0413e0: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @chayankumar999, @melinath, @slevenick VCR tests complete for b0413e0! |
b0413e0 to
ec12dc0
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ec12dc0: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @chayankumar999, @melinath VCR tests complete for ec12dc0! |
I don't know why it's still complaining about this, though it should have been added already. Also opening the link https://console.cloud.google.com/cloud-build/builds;region=global/11930931-69fc-4299-81e7-9a621a4b2399;step=17?project=graphite-docker-images from the failed check doesn't show any errors. |
|
Waiting on test rerun to finish, but it should pass |
fde8355
This PR introduces a new virtual resource for instance group managers: BulkPerInstanceConfig.
In this version it accepts only instance names which makes it possible to call instanceGroupManagers.CreateInstances with more than 1 instance in a single call. So far it was limited to a single PerInstanceConfig.
BulkPerInstanceConfig is immutable and on each modification it will call instanceGroupManagers.DeleteInstances on Destroy and instanceGroupManagers.CreateInstances on Create. Thanks to that Update is not implemented.
instance group manager should be configured to ignore target_size changes, as BulkPerInstanceConfig modifies this value.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.