Skip to content

Revert "[Internal Range] Fix for issue 27175"#17698

Merged
SirGitsalot merged 1 commit into
mainfrom
revert-17431-main
May 22, 2026
Merged

Revert "[Internal Range] Fix for issue 27175"#17698
SirGitsalot merged 1 commit into
mainfrom
revert-17431-main

Conversation

@SirGitsalot

Copy link
Copy Markdown
Member

Reverts #17431

This broken numerous tests outside of the compute package, with failures like:

------- Stdout: -------
=== RUN   TestAccContainerCluster_withAdvancedMachineFeaturesPMU_Standard
=== PAUSE TestAccContainerCluster_withAdvancedMachineFeaturesPMU_Standard
=== CONT  TestAccContainerCluster_withAdvancedMachineFeaturesPMU_Standard
    resource_container_cluster_test.go:15248: Step 1/2 error: After applying this test step, the refresh plan was not empty.
        stdout
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # google_compute_subnetwork.default will be updated in-place
          ~ resource "google_compute_subnetwork" "default" {
                id                               = "projects/ci-test-project-nightly-ga/regions/us-central1/subnetworks/test-subnetwork-cayfs20sbo"
                name                             = "test-subnetwork-cayfs20sbo"
                # (25 unchanged attributes hidden)
              - secondary_ip_range {
                  - ip_cidr_range           = "10.180.0.0/14" -> null
                  - range_name              = "gke-tf-test-cluster-cayfs20sbo-pods-5dbe89b6" -> null
                  - reserved_internal_range = "networkconnectivity.googleapis.com/projects/ci-test-project-nightly-ga/locations/global/internalRanges/gke-tf-test-cluster-cayfs20sbo-pods-5dbe89b6" -> null
                }
            }
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccContainerCluster_withAdvancedMachineFeaturesPMU_Standard (632.84s)
FAIL

@modular-magician

modular-magician commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e7ffbb3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 309 insertions(+), 496 deletions(-)
google-beta provider View Diff 5 files changed, 309 insertions(+), 496 deletions(-)
terraform-google-conversion View Diff 4 files changed, 37 insertions(+), 373 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field secondary_ip_range.ip_cidr_range lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1471 1376 93 2
Affected Service Packages
  • compute
  • networkconnectivityv1

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeSubnetwork_secondaryIpRanges
  • TestAccComputeSubnetwork_secondaryIpv6Ranges

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeSubnetwork_secondaryIpRanges
✅ Log TestAccComputeSubnetwork_secondaryIpv6Ranges

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@SirGitsalot, @NickElliot VCR tests complete for e7ffbb3!

@SirGitsalot SirGitsalot added this pull request to the merge queue May 22, 2026
Merged via the queue into main with commit fa94c7f May 22, 2026
30 of 32 checks passed
@SirGitsalot SirGitsalot deleted the revert-17431-main branch May 22, 2026 20:48
MikolajLuczko pushed a commit to MikolajLuczko/magic-modules that referenced this pull request May 28, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
muresan pushed a commit to muresan/magic-modules that referenced this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants