Skip to content

Revert "Fix bigtable_custom_endpoint ignoring config and dropping gRPC endpoints"#17697

Merged
SirGitsalot merged 1 commit into
mainfrom
revert-16958-fix-bigtable-custom-endpoint
May 22, 2026
Merged

Revert "Fix bigtable_custom_endpoint ignoring config and dropping gRPC endpoints"#17697
SirGitsalot merged 1 commit into
mainfrom
revert-16958-fix-bigtable-custom-endpoint

Conversation

@roaks3

@roaks3 roaks3 commented May 22, 2026

Copy link
Copy Markdown
Contributor

Reverts #16958

This caused a number of our nightly tests to fail, so it would seem something wasn't working and we need more robust testing

@roaks3 roaks3 requested a review from SirGitsalot May 22, 2026 19:15
@modular-magician

modular-magician commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ee1d4e3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 29 insertions(+), 128 deletions(-)
google-beta provider View Diff 2 files changed, 29 insertions(+), 128 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
66 0 66 0
Affected Service Packages
  • bigtable

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@roaks3, @SirGitsalot VCR tests complete for ee1d4e3!

@SirGitsalot

Copy link
Copy Markdown
Member

Example failure log:

------- Stdout: -------
=== RUN   TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample
=== PAUSE TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample
=== CONT  TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample
    resource_bigtable_app_profile_generated_test.go:68: Step 1/3 error: Error running apply: exit status 1
        Error: Error creating instance. rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp: address bigtableadmin.googleapis.com: missing port in address"
          with google_bigtable_instance.instance,
          on terraform_plugin_test.tf line 12, in resource "google_bigtable_instance" "instance":
          12: resource "google_bigtable_instance" "instance" {
--- FAIL: TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample (5.18s)
FAIL

@SirGitsalot SirGitsalot added this pull request to the merge queue May 22, 2026
@SirGitsalot

Copy link
Copy Markdown
Member

@mhandugan

Merged via the queue into main with commit 2c06c3c May 22, 2026
25 of 26 checks passed
@SirGitsalot SirGitsalot deleted the revert-16958-fix-bigtable-custom-endpoint branch May 22, 2026 19:39
MikolajLuczko pushed a commit to MikolajLuczko/magic-modules that referenced this pull request May 28, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants