Skip to content

Prepend migrated legacy examples to resource samples#17680

Merged
shuyama1 merged 1 commit into
mainfrom
example_first
May 21, 2026
Merged

Prepend migrated legacy examples to resource samples#17680
shuyama1 merged 1 commit into
mainfrom
example_first

Conversation

@shuyama1

@shuyama1 shuyama1 commented May 21, 2026

Copy link
Copy Markdown
Member

Ensures that legacy examples converted to samples (in-memory) are prepended and ordered before any newly added samples.

Since the generator uses the first example to generate any iam/datasource/list resource - this is to ensure any new samples added won't change what config is used to generate those tests before the migration is fully completed.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@shuyama1 shuyama1 requested a review from melinath May 21, 2026 22:35
@modular-magician

modular-magician commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c639468:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 98 insertions(+), 98 deletions(-)
google-beta provider View Diff 2 files changed, 98 insertions(+), 98 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
41 41 0 0
Affected Service Packages
  • workstations

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@shuyama1 VCR tests complete for c639468!

@shuyama1 shuyama1 added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 8ad1d76 May 21, 2026
29 checks passed
@shuyama1 shuyama1 deleted the example_first branch May 21, 2026 22:55
MikolajLuczko pushed a commit to MikolajLuczko/magic-modules that referenced this pull request May 28, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants