Skip to content

Migrate resource compute instance from template test to transport_tpg#17657

Merged
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
jcromanu:resource_compute_instance_from_template_test
May 22, 2026
Merged

Migrate resource compute instance from template test to transport_tpg#17657
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
jcromanu:resource_compute_instance_from_template_test

Conversation

@jcromanu

@jcromanu jcromanu commented May 20, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@github-actions github-actions Bot requested a review from zli82016 May 20, 2026 23:20
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3526184:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 11 insertions(+), 3 deletions(-)
google-beta provider View Diff 1 file changed, 11 insertions(+), 3 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1452 1359 93 0
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@jcromanu, @zli82016 VCR tests complete for 3526184!

@zli82016

Copy link
Copy Markdown
Member

For the changes in test files, the release note is not needed. Can you modify it? Thanks.

@zli82016 zli82016 requested a review from WentaoNi May 21, 2026 17:05
@jcromanu

Copy link
Copy Markdown
Contributor Author

@zli82016 release notes were updated

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 added this pull request to the merge queue May 22, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 7cfbd68 May 22, 2026
27 of 28 checks passed
@jcromanu jcromanu deleted the resource_compute_instance_from_template_test branch May 22, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants