Skip to content

increase timeouts on ephermeral service account key tests#17636

Merged
shuyama1 merged 3 commits into
GoogleCloudPlatform:mainfrom
NickElliot:ephemeralsakeytestfails
May 22, 2026
Merged

increase timeouts on ephermeral service account key tests#17636
shuyama1 merged 3 commits into
GoogleCloudPlatform:mainfrom
NickElliot:ephemeralsakeytestfails

Conversation

@NickElliot

Copy link
Copy Markdown
Contributor

Tests are flakey in nightlies for these resources #1 #2 It is unclear if this is some delay in permissions being propagated on the google_service_account resource, as these tests are functionally identical to TestAccDatasourceGoogleServiceAccountKey_basic, but that test is not flakey at all with no timeout adjustments. Will investigate further.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

modular-magician commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4866d4c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 14 insertions(+), 4 deletions(-)
google-beta provider View Diff 1 file changed, 14 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
175 143 30 2
Affected Service Packages
  • resourcemanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccEphemeralServiceAccountKey_create
  • TestAccEphemeralServiceAccountKey_upload

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ❌ Error · Log TestAccEphemeralServiceAccountKey_upload
❌ Error · Log - TestAccEphemeralServiceAccountKey_create

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NickElliot VCR tests complete for 4866d4c!

@modular-magician

modular-magician commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7f6b2cb:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 17 insertions(+), 4 deletions(-)
google-beta provider View Diff 1 file changed, 17 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
175 143 30 2
Affected Service Packages
  • resourcemanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccEphemeralServiceAccountKey_create
  • TestAccEphemeralServiceAccountKey_upload

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ❌ Error · Log TestAccEphemeralServiceAccountKey_create
✅ Log ❌ Error · Log TestAccEphemeralServiceAccountKey_upload

Caution

Issues requiring attention before PR completion

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NickElliot VCR tests complete for 7f6b2cb!

@NickElliot NickElliot marked this pull request as ready for review May 20, 2026 16:34
@NickElliot

Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from c2thorn May 20, 2026 16:35

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's going on with the VCR failure

@BBBmau

BBBmau commented May 20, 2026

Copy link
Copy Markdown
Collaborator

failing tests are resolved in this PR:

@modular-magician

modular-magician commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5027f0c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 17 insertions(+), 4 deletions(-)
google-beta provider View Diff 1 file changed, 17 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
175 144 30 1
Affected Service Packages
  • resourcemanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccProjectIamMemberRemove_memberInMultipleBindings

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings

Caution

Issues requiring attention before PR completion

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NickElliot VCR tests complete for 5027f0c!

@NickElliot NickElliot requested a review from c2thorn May 21, 2026 21:18

@shuyama1 shuyama1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VCR re-replaying error is due to non-determinism, which is not introduced by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants