increase timeouts on ephermeral service account key tests#17636
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4866d4c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @NickElliot VCR tests complete for 4866d4c! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7f6b2cb: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @NickElliot VCR tests complete for 7f6b2cb! |
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
c2thorn
left a comment
There was a problem hiding this comment.
what's going on with the VCR failure
|
failing tests are resolved in this PR: |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5027f0c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @NickElliot VCR tests complete for 5027f0c! |
shuyama1
left a comment
There was a problem hiding this comment.
The VCR re-replaying error is due to non-determinism, which is not introduced by this PR.
72e2406
Tests are flakey in nightlies for these resources #1 #2 It is unclear if this is some delay in permissions being propagated on the
google_service_accountresource, as these tests are functionally identical toTestAccDatasourceGoogleServiceAccountKey_basic, but that test is not flakey at all with no timeout adjustments. Will investigate further.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.