Skip to content

Add an output-only field for Firebase storage default bucket id#17632

Merged
shuyama1 merged 2 commits into
GoogleCloudPlatform:mainfrom
rainshen49:adminsdk
May 21, 2026
Merged

Add an output-only field for Firebase storage default bucket id#17632
shuyama1 merged 2 commits into
GoogleCloudPlatform:mainfrom
rainshen49:adminsdk

Conversation

@rainshen49

@rainshen49 rainshen49 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Add an output_only field for Firebase storage default bucket id. This is for convenience so that clients don't have to parse the resource name string.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

firebasestorage: added `bucket.bucket_id` field to `google_firebase_storage_default_bucket` resource (beta)

… is for convenience so that clients don't have to parse the resource name string.
@github-actions github-actions Bot requested a review from shuyama1 May 19, 2026 16:36
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 419d7f6:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 4 insertions(+)
google-beta provider View Diff 3 files changed, 15 insertions(+), 5 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
2 2 0 0
Affected Service Packages
  • firebasestorage

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@rainshen49, @jacksonic, @shuyama1 VCR tests complete for 419d7f6!

@modular-magician

modular-magician commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a715585:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 4 insertions(+)
google-beta provider View Diff 3 files changed, 15 insertions(+), 5 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
2 2 0 0
Affected Service Packages
  • firebasestorage

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@rainshen49, @jacksonic, @shuyama1 VCR tests complete for a715585!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants