Skip to content

Added allservices package that imports all services#17607

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:allservices-package
May 21, 2026
Merged

Added allservices package that imports all services#17607
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:allservices-package

Conversation

@melinath

@melinath melinath commented May 18, 2026

Copy link
Copy Markdown
Member

This is necessary to make importing all services an explicit choice. This will replace provider_register_services, which imports all services as a side effect of importing the provider package. It's in a separate PR so that the diff processor can run properly on the switchover PR. (Without this change, it fails to compile because allservices doesn't exist.)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


This is necessary to make importing all services an explicit choice. This will replace provider_register_services, which imports all services as a side effect of importing the provider package. It's in a separate PR so that the diff processor can run properly on the switchover PR.
@modular-magician

modular-magician commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e093605:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 196 insertions(+), 2 deletions(-)
google-beta provider View Diff 2 files changed, 207 insertions(+), 2 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6428 5754 656 18
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccEphemeralServiceAccountKey_create
  • TestAccEphemeralServiceAccountKey_upload
  • TestAccIapWebTypeAppEngineIamMemberGenerated
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
  • TestAccNetworkConnectivityDestination_update
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccSourceRepoRepositoryIamMemberGenerated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
✅ Log ❌ Error · Log TestAccDataformConfig_update
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccEphemeralServiceAccountKey_create
❌ Error · Log - TestAccEphemeralServiceAccountKey_upload
❌ Error · Log - TestAccIapWebTypeAppEngineIamMemberGenerated
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
❌ Error · Log - TestAccNetworkConnectivityDestination_update
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccSourceRepoRepositoryIamMemberGenerated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath, @SirGitsalot VCR tests complete for e093605!

@melinath melinath requested a review from SirGitsalot May 18, 2026 19:06
@melinath

Copy link
Copy Markdown
Member Author

VCR failures look unrelated

@melinath melinath added this pull request to the merge queue May 21, 2026
Merged via the queue into GoogleCloudPlatform:main with commit b0419cb May 21, 2026
25 of 26 checks passed
@melinath melinath deleted the allservices-package branch May 21, 2026 16:17
MikolajLuczko pushed a commit to MikolajLuczko/magic-modules that referenced this pull request May 28, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants