feat: Add data-source google_oracle_database_goldengate_deployment_environments#17599
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0ef4b0a: Diff reportYour PR generated the following diffs in downstream repositories:
Missing doc report (experimental)The following data sources are missing documents:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @swethamagesh14, @BBBmau VCR tests complete for 0ef4b0a! |
BBBmau
left a comment
There was a problem hiding this comment.
I'll need a bit more context surrounding the oralce database since I couldn't find much documentation about this resource on the first review.
Some questions I have:
- This PR introduces a plural datasource, though I would prefer we introduce a singular data source first before adding in plural
- Do we not have the ability to create a deployment environment? We should instead add resource support and follow-up with this PR that adds singluar data source as it will allow us to reuse the schema, reducing duplicate code from occurring
- docs are missing in this PR, we should provide links / guides that assist in using this deployment environment (this could also be applied to the resource itself and not the datasource)
Strictly read-only: In the upstream API, To create a Goldengate Deployment resource, you need metadata from deploymentEnvironment datasource to put in the right values. Links: |
BBBmau
left a comment
There was a problem hiding this comment.
Thanks for the explanation and links! This makes sense now given that this is strictly focusing on fetching the environments of the goldengate deployment.
We are still missing docs, once these are added i can approve and merge 👍🏼
…t_environments documentation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9834d07: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @swethamagesh14, @BBBmau VCR tests complete for 9834d07! |
0a182ce
Part of Issue
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.