Skip to content

feat: Add data-source google_oracle_database_goldengate_deployment_environments#17599

Merged
BBBmau merged 2 commits into
GoogleCloudPlatform:mainfrom
swethamagesh14:datasource-depenvs
May 21, 2026
Merged

feat: Add data-source google_oracle_database_goldengate_deployment_environments#17599
BBBmau merged 2 commits into
GoogleCloudPlatform:mainfrom
swethamagesh14:datasource-depenvs

Conversation

@swethamagesh14

@swethamagesh14 swethamagesh14 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Part of Issue

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_oracle_database_goldengate_deployment_environments`

@github-actions github-actions Bot requested a review from BBBmau May 18, 2026 07:57
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0ef4b0a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 239 insertions(+)
google-beta provider View Diff 2 files changed, 239 insertions(+)

Missing doc report (experimental)

The following data sources are missing documents:

  • google_oracle_database_goldengate_deployment_environments, expect file /website/docs/d/oracle_database_goldengate_deployment_environments.html.markdown to exist.

Test report

Analytics

Total Tests Passed Skipped Affected
30 28 2 0
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@swethamagesh14, @BBBmau VCR tests complete for 0ef4b0a!

@BBBmau BBBmau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need a bit more context surrounding the oralce database since I couldn't find much documentation about this resource on the first review.

Some questions I have:

  • This PR introduces a plural datasource, though I would prefer we introduce a singular data source first before adding in plural
  • Do we not have the ability to create a deployment environment? We should instead add resource support and follow-up with this PR that adds singluar data source as it will allow us to reuse the schema, reducing duplicate code from occurring
  • docs are missing in this PR, we should provide links / guides that assist in using this deployment environment (this could also be applied to the resource itself and not the datasource)

@swethamagesh14

Copy link
Copy Markdown
Contributor Author

I'll need a bit more context surrounding the oralce database since I couldn't find much documentation about this resource on the first review.

Some questions I have:

  • This PR introduces a plural datasource, though I would prefer we introduce a singular data source first before adding in plural
  • Do we not have the ability to create a deployment environment? We should instead add resource support and follow-up with this PR that adds singluar data source as it will allow us to reuse the schema, reducing duplicate code from occurring
  • docs are missing in this PR, we should provide links / guides that assist in using this deployment environment (this could also be applied to the resource itself and not the datasource)

Strictly read-only: In the upstream API, goldengateDeploymentEnvironments is a read-only metadata catalog managed by Oracle/Google. Since there are no CRUD endpoints (no create, update, or delete RPCs), it can only be queried and can't actually be represented as a Terraform resource.
Plural lookup design: The real resources users manage are deployments, connections, and assignments. To create those, you query this data source to list the available platform specs. This behaves similarly to read-only search queries in Terraform for our other datasources

To create a Goldengate Deployment resource, you need metadata from deploymentEnvironment datasource to put in the right values.

Links:
https://docs.oracle.com/en-us/iaas/api/#/en/goldengate/20200407/DeploymentEnvironmentCollection/ListDeploymentEnvironments
https://docs.oracle.com/en/cloud/paas/goldengate-service/druyg/
https://docs.cloud.google.com/oracle/database/docs/deploy-and-connect
https://docs.cloud.google.com/oracle/database/docs/overview

@github-actions github-actions Bot requested a review from BBBmau May 20, 2026 11:46

@BBBmau BBBmau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation and links! This makes sense now given that this is strictly focusing on fetching the environments of the goldengate deployment.

We are still missing docs, once these are added i can approve and merge 👍🏼

@modular-magician

modular-magician commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9834d07:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 312 insertions(+)
google-beta provider View Diff 3 files changed, 312 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
30 28 2 0
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@swethamagesh14, @BBBmau VCR tests complete for 9834d07!

@BBBmau BBBmau changed the title feat: Add resource google_oracle_database_goldengate_deployment_environments feat: Add data-source google_oracle_database_goldengate_deployment_environments May 21, 2026
@BBBmau BBBmau added this pull request to the merge queue May 21, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 0a182ce May 21, 2026
28 checks passed
MikolajLuczko pushed a commit to MikolajLuczko/magic-modules that referenced this pull request May 28, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
@swethamagesh14 swethamagesh14 deleted the datasource-depenvs branch June 24, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants