Skip to content

tgc-revival: fix RegionInstantSnapshot tests#17517

Merged
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
zli82016:tgc-fix-snapshot
May 11, 2026
Merged

tgc-revival: fix RegionInstantSnapshot tests#17517
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
zli82016:tgc-fix-snapshot

Conversation

@zli82016

@zli82016 zli82016 commented May 11, 2026

Copy link
Copy Markdown
Member
--- FAIL: TestAccComputeRegionInstantSnapshot (2.88s)
    --- FAIL: TestAccComputeRegionInstantSnapshot/TestAccComputeRegionInstantSnapshot_resourceManagerTags (2.88s)
        --- FAIL: TestAccComputeRegionInstantSnapshot/TestAccComputeRegionInstantSnapshot_resourceManagerTags/step1 (0.00s)
            assert_test_files.go:117: TestAccComputeRegionInstantSnapshot_resourceManagerTags_step1: Starting test with retry logic.
            assert_test_files.go:92: TestAccComputeRegionInstantSnapshot_resourceManagerTags_step1: Test for the primary resource google_compute_region_instant_snapshot.foobar begins.
panic: runtime error: slice bounds out of range [9:7] [recovered, repanicked]

I have modified RegionInstantSnapshot.yaml in Magic Modules to add cai_resource_kind: InstantSnapshot, which will ensure that both zonal and regional instant snapshots are grouped under the compute.googleapis.com/InstantSnapshot CAI asset type.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@zli82016 zli82016 marked this pull request as ready for review May 11, 2026 20:14
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fe72e0f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
terraform-google-conversion View Diff 4 files changed, 9 insertions(+), 7 deletions(-)

@zli82016 zli82016 requested a review from hao-nan-li May 11, 2026 20:51
@zli82016 zli82016 added this pull request to the merge queue May 11, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 3e37756 May 11, 2026
24 checks passed
@zli82016 zli82016 deleted the tgc-fix-snapshot branch May 11, 2026 21:44
pragya644 pushed a commit to pragya644/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants