Skip to content

Feat: add excluded projects and folders examples in google compute organization security policy association resource - #17511

Merged
BBBmau merged 2 commits into
GoogleCloudPlatform:mainfrom
victorsantos-cit:feat/add-excluded-projects-and-folders-examples-in-google_compute_organization_security_policy_association
May 12, 2026
Merged

Feat: add excluded projects and folders examples in google compute organization security policy association resource#17511
BBBmau merged 2 commits into
GoogleCloudPlatform:mainfrom
victorsantos-cit:feat/add-excluded-projects-and-folders-examples-in-google_compute_organization_security_policy_association

Conversation

@victorsantos-cit

Copy link
Copy Markdown
Contributor

Hello Folks, this PR is to create a example to how to use a excluded_projects and excluded_folders on google_compute_organization_security_policy_association resource

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `excluded_projects` and `excluded_folders` example to `google_compute_organization_security_policy_association` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 11, 2026
@github-actions
github-actions Bot requested a review from BBBmau May 11, 2026 19:07
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/compute-security-policy and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 11, 2026
@modular-magician

modular-magician commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d87c5cc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 97 insertions(+)
google-beta provider View Diff 2 files changed, 97 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
1446 1349 93 4
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationExcludedExample
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationExcludedExample
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@victorsantos-cit, @BBBmau VCR tests complete for d87c5cc!

@BBBmau BBBmau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! failing VCR tests are unrelated

@BBBmau
BBBmau added this pull request to the merge queue May 12, 2026
Merged via the queue into GoogleCloudPlatform:main with commit ee4f5dc May 12, 2026
26 of 27 checks passed
pragya644 pushed a commit to pragya644/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants