Migrate resource_compute_shared_vpc_service_project.go.tmpl to new API

[inadenenko]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `google_compute_shared_vpc_service_project` to use direct HTTP rather than a client library

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[melinath]

I haven't really reviewed this, since it needs review from @WentaoNi first. But I did notice the ComputeBasePath usage and just wanted to flag that since we're looking to remove it in the next day or two & want to avoid churn for us & y'all related to that.

[melinath]

We're about to remove ComputeBasePath from the config object; please use transport_tpg.BaseUrl(Product, config) instead.

Attn @WentaoNi FYI since this impacts all these migrations.

Suggested change

	url := fmt.Sprintf("%sprojects/%s/enableXpnResource", config.ComputeBasePath, hostProject)
	url := fmt.Sprintf("%sprojects/%s/enableXpnResource", transport_tpg.BaseUrl(Product, config), hostProject)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c7813e7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	1 file changed, 39 insertions(+), 20 deletions(-)
google-beta provider	View Diff	1 file changed, 39 insertions(+), 20 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1445	1350	93	2

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceFromTemplate_DiskForceAttach
• TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@inadenenko, @melinath VCR tests complete for c7813e7!

[github-actions]

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

@inadenenko @WentaoNi FYI the release notes should be focused on the user impact - so what's important is the resource(s) that could end up with problems due to the migration. I've modified the release note on this PR, and we've also been editing them on releases: https://github.com/hashicorp/terraform-provider-google-beta/releases but it would save some time in review / release if the notes were properly formatted on PRs.

[melinath]

Changes look good. VCR for this resource's tests passed in replaying mode locally.