Tavasyag/storagebucket list

[tavasyag]

This adds handwritten list-resource support for google_storage_bucket.

Fixes hashicorp/terraform-provider-google#27367

Changes in this PR:

• add handwritten google_storage_bucket list resource
• add acceptance coverage for terraform query identity results
• add list-resource documentation for google_storage_bucket

Testing

make testacc TEST=./google/services/storage TESTARGS='-run=TestAccStorageBucketListResource_queryIdentity$$'

=== RUN   TestAccStorageBucketListResource_queryIdentity
=== PAUSE TestAccStorageBucketListResource_queryIdentity
=== CONT  TestAccStorageBucketListResource_queryIdentity
--- PASS: TestAccStorageBucketListResource_queryIdentity (7.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-google/google/services/storage	8.312s

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

'list_google_storage_bucket'

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 83e23e5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	4 files changed, 417 insertions(+), 1 deletion(-)
google-beta provider	View Diff	4 files changed, 417 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
134	122	11	1

Affected Service Packages

• storage

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageBucketListResource_queryIdentity

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccStorageBucketListResource_queryIdentity

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@tavasyag, @kautikdk VCR tests complete for 83e23e5!

[BBBmau]

the refactors on how we introduce list resources really made this easier to review compare to before 😄

[kautikdk]

I am not very much familiar with the list-resources so requesting @BBBmau for full review.
Thanks @tavasyag for the contribution! Can you please create one GitHub issue here: https://github.com/hashicorp/terraform-provider-google/issues to track the work and to avoid duplicate effort by other contributors?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fbc06b2:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	6 files changed, 507 insertions(+), 4 deletions(-)
google-beta provider	View Diff	6 files changed, 507 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
135	123	11	1

Affected Service Packages

• storage

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageBucket_importBlockWithResourceIdentity

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccStorageBucket_importBlockWithResourceIdentity

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@tavasyag, @kautikdk VCR tests complete for fbc06b2!

[tavasyag]

Waiting on #17543 to be merged so I can update transport to use ListPages() func instead of
https://github.com/GoogleCloudPlatform/magic-modules/pull/17500/changes#diff-a683cad3f887ca05289be3e1d28396b7543395477fcb4d5fb5efe41757c6779fR140-R196

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 739c9bb:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	6 files changed, 457 insertions(+), 4 deletions(-)
google-beta provider	View Diff	6 files changed, 457 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
135	124	11	0

Affected Service Packages

• storage

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@tavasyag, @kautikdk VCR tests complete for 739c9bb!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 12bd3ee:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	6 files changed, 446 insertions(+), 4 deletions(-)
google-beta provider	View Diff	6 files changed, 446 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
135	123	11	1

Affected Service Packages

• storage

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccStorageBucket_importBlockWithResourceIdentity

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccStorageBucket_importBlockWithResourceIdentity

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@tavasyag, @kautikdk VCR tests complete for 12bd3ee!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fe3085b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	6 files changed, 446 insertions(+), 4 deletions(-)
google-beta provider	View Diff	6 files changed, 446 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
135	124	11	0

Affected Service Packages

• storage

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@tavasyag, @kautikdk VCR tests complete for fe3085b!

[BBBmau]

Good work!