Skip to content

Promote PodSnapshotConfig from Beta to GA#17499

Merged
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
saketjajoo:gke-pod-snapshots-ga
May 12, 2026
Merged

Promote PodSnapshotConfig from Beta to GA#17499
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
saketjajoo:gke-pod-snapshots-ga

Conversation

@saketjajoo

Copy link
Copy Markdown
Member

The GKE Pod Snapshots feature is now fully rolled out in google.golang.org/api's v1 version (ref). This change aims to promote the API in the terraform provider from beta to GA.

Internal Ref: b/469789865.
PR implementing the Beta APIs: #16096.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `pod_snapshot_config` field to `google_container_cluster` resource (GA)

@github-actions github-actions Bot requested a review from zli82016 May 9, 2026 23:52
@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@saketjajoo

Copy link
Copy Markdown
Member Author

/cc @CoderSherlock

@modular-magician

modular-magician commented May 10, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 71a91ba:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 41 insertions(+), 1 deletion(-)
google-beta provider View Diff 4 files changed, 41 insertions(+), 42 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
291 274 15 2
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_updateVersion
  • TestAccContainerNodePool_withHostMaintenancePolicy

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContainerCluster_updateVersion
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@saketjajoo, @zli82016 VCR tests complete for 71a91ba!

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zli82016

Copy link
Copy Markdown
Member

Failed test is not related.

@zli82016 zli82016 added this pull request to the merge queue May 12, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 8caaa07 May 12, 2026
21 of 22 checks passed
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants