Skip to content

Fixed ApigeeOrganization tests#17467

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:fix-apigee-organization-wait-after-destroy
May 11, 2026
Merged

Fixed ApigeeOrganization tests#17467
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:fix-apigee-organization-wait-after-destroy

Conversation

@melinath

@melinath melinath commented May 7, 2026

Copy link
Copy Markdown
Member

The dependency order for the wait_after_destroy was backwards (see docs). This fixes it.

Fixed hashicorp/terraform-provider-google#24143. Fixed hashicorp/terraform-provider-google#25281.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


The dependency order for the wait_after_destroy was backwards
@melinath

melinath commented May 7, 2026

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9a0f60c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 14 insertions(+), 15 deletions(-)
google-beta provider View Diff 1 file changed, 34 insertions(+), 35 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
75 35 38 2
Affected Service Packages
  • apigee

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
✅ Log TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@melinath, @zli82016 VCR tests complete for 9a0f60c!

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests.

@melinath melinath added this pull request to the merge queue May 11, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 1d01f16 May 11, 2026
23 checks passed
@melinath melinath deleted the fix-apigee-organization-wait-after-destroy branch May 11, 2026 23:45
pragya644 pushed a commit to pragya644/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants