Skip to content

Moved compute-related bootstrapping into the compute package#17461

Merged
melinath merged 2 commits into
GoogleCloudPlatform:mainfrom
melinath:split-bootstrap-2
May 8, 2026
Merged

Moved compute-related bootstrapping into the compute package#17461
melinath merged 2 commits into
GoogleCloudPlatform:mainfrom
melinath:split-bootstrap-2

Conversation

@melinath

@melinath melinath commented May 7, 2026

Copy link
Copy Markdown
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

modular-magician commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b294ca3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 45 files changed, 1362 insertions(+), 1250 deletions(-)
google-beta provider View Diff 46 files changed, 1396 insertions(+), 1280 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6401 5728 655 18
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
  • TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyWithAdvancedOptionsExample
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
  • TestAccContainerCluster_updateVersion
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataSourceGoogleCloudRunService_basic
  • TestAccDataSourceGoogleCloudRunService_optionalProject
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
✅ Log TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
✅ Log TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyWithAdvancedOptionsExample
❌ Error · Log - TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
❌ Error · Log - TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
❌ Error · Log - TestAccContainerCluster_updateVersion
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataSourceGoogleCloudRunService_basic
❌ Error · Log - TestAccDataSourceGoogleCloudRunService_optionalProject
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@melinath, @SirGitsalot VCR tests complete for b294ca3!

@melinath melinath requested a review from SirGitsalot May 7, 2026 18:14
@melinath

melinath commented May 7, 2026

Copy link
Copy Markdown
Member Author

I don't see any conflicts with EAP from this one.

@melinath

melinath commented May 7, 2026

Copy link
Copy Markdown
Member Author

VCR failures look unrelated.

@melinath melinath added this pull request to the merge queue May 8, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 37b4def May 8, 2026
24 of 25 checks passed
@melinath melinath deleted the split-bootstrap-2 branch May 8, 2026 20:15
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
jbbqqf pushed a commit to jbbqqf/magic-modules that referenced this pull request May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants