Skip to content

Migrate resource_project_usage_export_bucket.go.tmpl to use transport_tpg.SendRequest#17429

Merged
malhotrasagar2212 merged 1 commit into
GoogleCloudPlatform:mainfrom
iliatsuprik:export_bucket
May 11, 2026
Merged

Migrate resource_project_usage_export_bucket.go.tmpl to use transport_tpg.SendRequest#17429
malhotrasagar2212 merged 1 commit into
GoogleCloudPlatform:mainfrom
iliatsuprik:export_bucket

Conversation

@iliatsuprik

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

This change migrates ResourceProjectUsageBucket resource to use transport_tpg.SendRequest instead of NewClient

@modular-magician

modular-magician commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8f22c8f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 48 insertions(+), 11 deletions(-)
google-beta provider View Diff 1 file changed, 48 insertions(+), 11 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1427 1335 91 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeResourceUsageExportBucket

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeResourceUsageExportBucket

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@iliatsuprik VCR tests complete for 8f22c8f!

@iliatsuprik iliatsuprik marked this pull request as ready for review May 6, 2026 13:57
@github-actions github-actions Bot requested a review from malhotrasagar2212 May 6, 2026 13:57
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions

Copy link
Copy Markdown

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@malhotrasagar2212 malhotrasagar2212 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@malhotrasagar2212 malhotrasagar2212 added this pull request to the merge queue May 11, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 4e9f4cf May 11, 2026
23 checks passed
pragya644 pushed a commit to pragya644/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants