Migrate resource_compute_network_test.go.tmpl resource to use direct HTTP rather than a client library#17354
Conversation
38ca68e to
6f697ee
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6f697ee: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
🟢 All tests passed! View the build log or the debug logs folder for detailed results. @nsamartsev VCR tests complete for 6f697ee! |
6f697ee to
907104b
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 907104b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the build log @nsamartsev VCR tests complete for 907104b! |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
melinath
left a comment
There was a problem hiding this comment.
could you fix the merge conflict?
907104b to
55b99ab
Compare
Done. |
This comment was marked as outdated.
This comment was marked as outdated.
55b99ab to
fd5ea9a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
| config.Project, network.Name).Do() | ||
| networkName, _ := (*network)["name"].(string) | ||
| url := fmt.Sprintf("%sprojects/%s/global/networks/%s", | ||
| config.ComputeBasePath, config.Project, networkName) |
There was a problem hiding this comment.
There are some more of these, I'm not going to mark them all since it's a simple find+replace. Please fix all of them. Thanks!
There was a problem hiding this comment.
Hello Stephen,
I've applied your suggestions and replaced the others, and I squashed all the commits into one.
Thanks for your comments and improvements!
|
The VCR failures above look unrelated and all related tests pass in replaying mode locally. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
685f92e to
5328cca
Compare
…t HTTP rather than a client library
5328cca to
f0d2763
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f0d2763: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @nsamartsev, @melinath VCR tests complete for f0d2763! |
melinath
left a comment
There was a problem hiding this comment.
looks good, seems like the same logic. The VCR failures are unrelated.
|
Related tests still pass in local replaying too. |
cd05ed5
…t HTTP rather than a client library (GoogleCloudPlatform#17354)
…t HTTP rather than a client library (GoogleCloudPlatform#17354)
…t HTTP rather than a client library (GoogleCloudPlatform#17354)
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.