Skip to content

Migrate resource_compute_network_test.go.tmpl resource to use direct HTTP rather than a client library#17354

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-network-test-migration
May 11, 2026
Merged

Migrate resource_compute_network_test.go.tmpl resource to use direct HTTP rather than a client library#17354
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-network-test-migration

Conversation

@nsamartsev

@nsamartsev nsamartsev commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Migrate `resource_compute_network_test.go.tmpl` resource to use direct HTTP rather than a client library

@WentaoNi WentaoNi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auto-pr branch is not generated.

@nsamartsev nsamartsev force-pushed the resource-compute-network-test-migration branch from 38ca68e to 6f697ee Compare May 6, 2026 12:49
@modular-magician

modular-magician commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6f697ee:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 148 insertions(+), 64 deletions(-)
google-beta provider View Diff 1 file changed, 148 insertions(+), 64 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1427 1335 91 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 6f697ee!

@nsamartsev nsamartsev force-pushed the resource-compute-network-test-migration branch from 6f697ee to 907104b Compare May 6, 2026 13:04
@modular-magician

modular-magician commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 907104b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 148 insertions(+), 64 deletions(-)
google-beta provider View Diff 1 file changed, 148 insertions(+), 64 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1427 1336 91 0
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@nsamartsev VCR tests complete for 907104b!

@nsamartsev nsamartsev marked this pull request as ready for review May 6, 2026 17:00
@github-actions github-actions Bot requested a review from melinath May 6, 2026 17:01
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you fix the merge conflict?

@nsamartsev nsamartsev force-pushed the resource-compute-network-test-migration branch from 907104b to 55b99ab Compare May 8, 2026 21:26
@github-actions github-actions Bot requested a review from melinath May 8, 2026 21:27
@nsamartsev

Copy link
Copy Markdown
Contributor Author

could you fix the merge conflict?

Done.
Once the CI is green, feel free to review.
Many thanks.

@modular-magician

This comment was marked as outdated.

@nsamartsev nsamartsev force-pushed the resource-compute-network-test-migration branch from 55b99ab to fd5ea9a Compare May 8, 2026 21:39
@modular-magician

This comment was marked as outdated.

Comment thread mmv1/third_party/terraform/services/compute/resource_compute_network_test.go.tmpl Outdated
Comment thread mmv1/third_party/terraform/services/compute/resource_compute_network_test.go.tmpl Outdated
Comment thread mmv1/third_party/terraform/services/compute/resource_compute_network_test.go.tmpl Outdated
Comment thread mmv1/third_party/terraform/services/compute/resource_compute_network_test.go.tmpl Outdated
config.Project, network.Name).Do()
networkName, _ := (*network)["name"].(string)
url := fmt.Sprintf("%sprojects/%s/global/networks/%s",
config.ComputeBasePath, config.Project, networkName)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some more of these, I'm not going to mark them all since it's a simple find+replace. Please fix all of them. Thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Stephen,
I've applied your suggestions and replaced the others, and I squashed all the commits into one.
Thanks for your comments and improvements!

@melinath

melinath commented May 8, 2026

Copy link
Copy Markdown
Member

The VCR failures above look unrelated and all related tests pass in replaying mode locally.

@github-actions github-actions Bot requested a review from melinath May 11, 2026 08:07
@nsamartsev nsamartsev marked this pull request as draft May 11, 2026 08:07
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@nsamartsev nsamartsev force-pushed the resource-compute-network-test-migration branch from 685f92e to 5328cca Compare May 11, 2026 08:18
@nsamartsev nsamartsev force-pushed the resource-compute-network-test-migration branch from 5328cca to f0d2763 Compare May 11, 2026 08:24
@modular-magician

This comment was marked as outdated.

@modular-magician

modular-magician commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f0d2763:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 150 insertions(+), 64 deletions(-)
google-beta provider View Diff 1 file changed, 150 insertions(+), 64 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1445 1350 93 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@nsamartsev, @melinath VCR tests complete for f0d2763!

@nsamartsev nsamartsev marked this pull request as ready for review May 11, 2026 09:13

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, seems like the same logic. The VCR failures are unrelated.

@melinath

Copy link
Copy Markdown
Member

Related tests still pass in local replaying too.

@melinath melinath added this pull request to the merge queue May 11, 2026
Merged via the queue into GoogleCloudPlatform:main with commit cd05ed5 May 11, 2026
21 of 22 checks passed
@nsamartsev nsamartsev deleted the resource-compute-network-test-migration branch May 11, 2026 16:01
pragya644 pushed a commit to pragya644/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants